This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11722

rhg: implement the debugignorerhg subcommand
ClosedPublic

Authored by aalekseyev on Oct 27 2021, 7:42 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG6d4daf51283c: rhg: implement the debugignorerhg subcommand
Summary

This can be used to inspect the generated pattern, but also to benchmark
the time it takes to parse hgignore.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

aalekseyev created this revision.Oct 27 2021, 7:42 AM
aalekseyev retitled this revision from rhg: implement the rhg-debugignore subcommand to rhg: implement the debugignorerhg subcommand.Oct 27 2021, 7:44 AM
aalekseyev added a comment.EditedOct 27 2021, 7:52 AM

<a comment posted in the wrong thread by accident>

aalekseyev updated this revision to Diff 30993.Oct 27 2021, 7:56 AM
aalekseyev updated this revision to Diff 30997.Oct 27 2021, 2:48 PM
Alphare added a subscriber: Alphare.Oct 28 2021, 5:40 AM

I'll look at these patches and take them after 6.0 is out (this includes the one I've already accepted). It's been delayed quite a bit due to Windows issues.

Alphare requested changes to this revision.Nov 24 2021, 4:48 AM

Thanks for waiting for so long. 6.0 is out (it was delayed a lot for Windows reasons), so I'll be back to reviewing patches for default.

rust/hg-core/src/matchers.rs
602

It would be nice to have a type alias for this (and the one below). We already have one in hg-core/src/dirstate/status.rs, probably should be refactored.

rust/rhg/src/commands/debugignorerhg.rs
18

nit: we prefer new commands to have dashes in them now, but it's really not a big deal since this is temporary anyway

This revision now requires changes to proceed.Nov 24 2021, 4:48 AM
aalekseyev edited the summary of this revision. (Show Details)Nov 26 2021, 2:35 PM
aalekseyev updated this revision to Diff 31169.
aalekseyev updated this revision to Diff 31170.Nov 26 2021, 2:42 PM
aalekseyev updated this revision to Diff 31171.Nov 26 2021, 2:45 PM
aalekseyev updated this revision to Diff 31172.Nov 26 2021, 2:49 PM
aalekseyev added inline comments.Nov 26 2021, 2:49 PM
rust/hg-core/src/matchers.rs
602

I used the alias from status.rs now.

rust/rhg/src/commands/debugignorerhg.rs
18

I'm not sure how to do that, actually. I tried renaming the command to debugignorerhg, but got an error:

468 |     debugignore-rhg
    |                ^ no rules expected this token in macro call
Alphare accepted this revision.Nov 29 2021, 6:08 AM
Alphare added inline comments.
rust/rhg/src/commands/debugignorerhg.rs
18

Ah right, we'd need a smarter macro, this is well out of scope

This revision is now accepted and ready to land.Nov 29 2021, 6:08 AM
Alphare requested changes to this revision.Nov 29 2021, 6:18 AM

Actually this also results in a folded commit, please re-send

This revision now requires changes to proceed.Nov 29 2021, 6:18 AM
aalekseyev edited the summary of this revision. (Show Details)Nov 29 2021, 8:03 AM
aalekseyev updated this revision to Diff 31185.
aalekseyev added a comment.Nov 29 2021, 8:05 AM

@Alphare, folded commit seems better than the separate ones in this case, though, since the second commit is simply incorporating review comments, not really an independent change.
I ran hg fold --from .^ followed by hg phabsend . to make this less confusing.

If you were thinking of a certain logical split of this commit into two that I'm not aware of, please let me know.

Alphare added a comment.Nov 29 2021, 8:37 AM
In D11722#181171, @aalekseyev wrote:

@Alphare, folded commit seems better than the separate ones in this case, though, since the second commit is simply incorporating review comments, not really an independent change.
I ran hg fold --from .^ followed by hg phabsend . to make this less confusing.
If you were thinking of a certain logical split of this commit into two that I'm not aware of, please let me know.

Sure, most of the time, changes can be incorporated into the same changeset, but for ones that move a lot of code around (like refactor suggestions), we usually like to split them. This has a two-fold advantage of making the review of the actual change more obvious, and to make sure a mistake didn't appear in the refactor.

In this case, I should have been more explicit: I saw two concatenated commit messages and figured you already had two changesets, so I asked you to send them as separate.

Basically: one changeset == one phab diff

aalekseyev added a comment.Nov 29 2021, 8:43 AM

@Alphare, Ok. I understood you before, but those commits were not suitable for independent submission.

I only have one commit now. Would you like me to split something out into a separate commit?

Alphare requested changes to this revision.Nov 29 2021, 8:52 AM

Yes, I think in this case a separate changeset for the type refactor (of the old code) would make sense.

Also I was sure I added a comment about the println! usage, but I must have forgotten!

rust/rhg/src/commands/debugignorerhg.rs
38

This should use ui.write_stdout, which would also remove the need for the potentially lossy utf8 conversion.

This revision now requires changes to proceed.Nov 29 2021, 8:52 AM
aalekseyev added a parent revision: D11818: rhg: refactor to use IgnoreFnType alias more widely.Nov 29 2021, 9:09 AM
aalekseyev edited the summary of this revision. (Show Details)
aalekseyev updated this revision to Diff 31187.
aalekseyev marked an inline comment as done.Nov 29 2021, 9:11 AM

Done. The refactor part was extracted into https://phab.mercurial-scm.org/D11818.

Alphare accepted this revision.Nov 29 2021, 9:12 AM

Thanks, both look good.

This revision is now accepted and ready to land.Nov 29 2021, 9:12 AM
aalekseyev added a commit: rHG6d4daf51283c: rhg: implement the debugignorerhg subcommand.Nov 29 2021, 10:44 AM
Closed by commit rHG6d4daf51283c: rhg: implement the debugignorerhg subcommand (authored by aalekseyev). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 31189

rust/hg-core/src/matchers.rs

}), }),
) )
}) })
} }
/// Parses all "ignore" files with their recursive includes and returns a /// Parses all "ignore" files with their recursive includes and returns a
/// function that checks whether a given file (in the general sense) should be /// function that checks whether a given file (in the general sense) should be
/// ignored. /// ignored.
pub fn get_ignore_function<'a>( pub fn get_ignore_matcher<'a>(
mut all_pattern_files: Vec<PathBuf>, mut all_pattern_files: Vec<PathBuf>,
root_dir: &Path, root_dir: &Path,
inspect_pattern_bytes: &mut impl FnMut(&[u8]), inspect_pattern_bytes: &mut impl FnMut(&[u8]),
) -> PatternResult<(IgnoreFnType<'a>, Vec<PatternFileWarning>)> { ) -> PatternResult<(IncludeMatcher<'a>, Vec<PatternFileWarning>)> {
let mut all_patterns = vec![]; let mut all_patterns = vec![];
let mut all_warnings = vec![]; let mut all_warnings = vec![];
// Sort to make the ordering of calls to `inspect_pattern_bytes` // Sort to make the ordering of calls to `inspect_pattern_bytes`
// deterministic even if the ordering of `all_pattern_files` is not (such // deterministic even if the ordering of `all_pattern_files` is not (such
// as when a iteration order of a Python dict or Rust HashMap is involved). // as when a iteration order of a Python dict or Rust HashMap is involved).
// Sort by "string" representation instead of the default by component // Sort by "string" representation instead of the default by component
// (with a Rust-specific definition of a component) // (with a Rust-specific definition of a component)
all_pattern_files all_pattern_files
.sort_unstable_by(|a, b| a.as_os_str().cmp(b.as_os_str())); .sort_unstable_by(|a, b| a.as_os_str().cmp(b.as_os_str()));
for pattern_file in &all_pattern_files { for pattern_file in &all_pattern_files {
let (patterns, warnings) = get_patterns_from_file( let (patterns, warnings) = get_patterns_from_file(
pattern_file, pattern_file,
root_dir, root_dir,
inspect_pattern_bytes, inspect_pattern_bytes,
)?; )?;
all_patterns.extend(patterns.to_owned()); all_patterns.extend(patterns.to_owned());
all_warnings.extend(warnings); all_warnings.extend(warnings);
} }
let matcher = IncludeMatcher::new(all_patterns)?; let matcher = IncludeMatcher::new(all_patterns)?;
Ok(( Ok((matcher, all_warnings))
Box::new(move |path: &HgPath| matcher.matches(path)), }
all_warnings,
)) /// Parses all "ignore" files with their recursive includes and returns a
/// function that checks whether a given file (in the general sense) should be
/// ignored.
pub fn get_ignore_function<'a>(
all_pattern_files: Vec<PathBuf>,
root_dir: &Path,
inspect_pattern_bytes: &mut impl FnMut(&[u8]),
) -> PatternResult<(IgnoreFnType<'a>, Vec<PatternFileWarning>)> {
let res =
AlphareUnsubmitted
Not Done

It would be nice to have a type alias for this (and the one below). We already have one in hg-core/src/dirstate/status.rs, probably should be refactored.

Alphare: It would be nice to have a type alias for this (and the one below). We already have one in `hg…
aalekseyevAuthorUnsubmitted
Done

I used the alias from status.rs now.

aalekseyev: I used the alias from status.rs now.
get_ignore_matcher(all_pattern_files, root_dir, inspect_pattern_bytes);
res.map(|(matcher, all_warnings)| {
let res: IgnoreFnType<'a> =
Box::new(move |path: &HgPath| matcher.matches(path));
(res, all_warnings)
})
} }
impl<'a> IncludeMatcher<'a> { impl<'a> IncludeMatcher<'a> {
pub fn new(ignore_patterns: Vec<IgnorePattern>) -> PatternResult<Self> { pub fn new(ignore_patterns: Vec<IgnorePattern>) -> PatternResult<Self> {
let RootsDirsAndParents { let RootsDirsAndParents {
roots, roots,
dirs, dirs,
parents, parents,
// TODO cache // TODO cache
let thing = self let thing = self
.dirs .dirs
.iter() .iter()
.chain(self.roots.iter()) .chain(self.roots.iter())
.chain(self.parents.iter()); .chain(self.parents.iter());
DirsChildrenMultiset::new(thing, Some(&self.parents)) DirsChildrenMultiset::new(thing, Some(&self.parents))
} }
pub fn debug_get_patterns(&self) -> &[u8] {
self.patterns.as_ref()
}
} }
impl<'a> Display for IncludeMatcher<'a> { impl<'a> Display for IncludeMatcher<'a> {
fn fmt(&self, f: &mut Formatter<'_>) -> Result<(), Error> { fn fmt(&self, f: &mut Formatter<'_>) -> Result<(), Error> {
// XXX What about exact matches? // XXX What about exact matches?
// I'm not sure it's worth it to clone the HashSet and keep it // I'm not sure it's worth it to clone the HashSet and keep it
// around just in case someone wants to display the matcher, plus // around just in case someone wants to display the matcher, plus
// it's going to be unreadable after a few entries, but we need to // it's going to be unreadable after a few entries, but we need to

rust/rhg/src/commands/debugignorerhg.rs

  • This file was added.
use crate::error::CommandError;
use clap::SubCommand;
use hg;
use hg::matchers::get_ignore_matcher;
use hg::StatusError;
use log::warn;
pub const HELP_TEXT: &str = "
Show effective hgignore patterns used by rhg.
This is a pure Rust version of `hg debugignore`.
Some options might be missing, check the list below.
";
pub fn args() -> clap::App<'static, 'static> {
SubCommand::with_name("debugignorerhg").about(HELP_TEXT)
}
AlphareUnsubmitted
Not Done

nit: we prefer new commands to have dashes in them now, but it's really not a big deal since this is temporary anyway

Alphare: nit: we prefer new commands to have dashes in them now, but it's really not a big deal since…
aalekseyevAuthorUnsubmitted
Done

I'm not sure how to do that, actually. I tried renaming the command to debugignorerhg, but got an error:

468 |     debugignore-rhg
    |                ^ no rules expected this token in macro call
aalekseyev: I'm not sure how to do that, actually. I tried renaming the command to debugignorerhg, but got…
AlphareUnsubmitted
Not Done

Ah right, we'd need a smarter macro, this is well out of scope

Alphare: Ah right, we'd need a smarter macro, this is well out of scope
pub fn run(invocation: &crate::CliInvocation) -> Result<(), CommandError> {
let repo = invocation.repo?;
let ignore_file = repo.working_directory_vfs().join(".hgignore"); // TODO hardcoded
let (ignore_matcher, warnings) = get_ignore_matcher(
vec![ignore_file],
&repo.working_directory_path().to_owned(),
&mut |_pattern_bytes| (),
)
.map_err(|e| StatusError::from(e))?;
if !warnings.is_empty() {
warn!("Pattern warnings: {:?}", &warnings);
}
let patterns = ignore_matcher.debug_get_patterns();
invocation.ui.write_stdout(patterns)?;
invocation.ui.write_stdout(b"\n")?;
AlphareUnsubmitted
Done

This should use ui.write_stdout, which would also remove the need for the potentially lossy utf8 conversion.

Alphare: This should use `ui.write_stdout`, which would also remove the need for the potentially lossy…
Ok(())
}

rust/rhg/src/main.rs

} }
}; };
} }
subcommands! { subcommands! {
cat cat
debugdata debugdata
debugrequirements debugrequirements
debugignorerhg
files files
root root
config config
status status
} }
pub struct CliInvocation<'a> { pub struct CliInvocation<'a> {
ui: &'a Ui, ui: &'a Ui,