This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11725

windows: use raw string in test log paths
ClosedPublic

Authored by Alphare on Oct 28 2021, 5:19 AM.

Details

Reviewers
spectral
Group Reviewers
hg-reviewers
Commits
rHG7a4d187479b6: windows: use raw string in test log paths
Summary

Otherwise the backslashes will work as escapes on Windows and break everything.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Oct 28 2021, 5:19 AM
spectral accepted this revision.Oct 29 2021, 4:30 PM
Alphare added a commit: rHG7a4d187479b6: windows: use raw string in test log paths.Oct 30 2021, 7:14 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG7a4d187479b6: windows: use raw string in test log paths (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-fix.t (2 lines)

Diff 31010

tests/test-fix.t

$ printf "bar4" > bar.log $ printf "bar4" > bar.log
$ LOGFILE=$TESTTMP/log $ LOGFILE=$TESTTMP/log
$ LOGGER=$TESTTMP/log.py $ LOGGER=$TESTTMP/log.py
$ cat >> $LOGGER <<EOF $ cat >> $LOGGER <<EOF
> # Appends the input file's name to the log file. > # Appends the input file's name to the log file.
> import sys > import sys
> with open('$LOGFILE', 'a') as f: > with open(r'$LOGFILE', 'a') as f:
> f.write(sys.argv[1] + '\n') > f.write(sys.argv[1] + '\n')
> sys.stdout.write(sys.stdin.read()) > sys.stdout.write(sys.stdin.read())
> EOF > EOF
$ hg fix --working-dir -r "all()" \ $ hg fix --working-dir -r "all()" \
> --config "fix.log:command=\"$PYTHON\" \"$LOGGER\" {rootpath}" \ > --config "fix.log:command=\"$PYTHON\" \"$LOGGER\" {rootpath}" \
> --config "fix.log:pattern=glob:**.log" > --config "fix.log:pattern=glob:**.log"