This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11730

pull: make the new argument a keyword argument
ClosedPublic

Authored by marmoute on Oct 29 2021, 9:33 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGaad84024660f: pull: make the new argument a keyword argument
Summary

As per feedback from Dan Villiom Podlaski Christiansen
in https://phab.mercurial-scm.org/D11674#179866

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Oct 29 2021, 9:33 AM
Alphare accepted this revision.Oct 29 2021, 9:34 AM
Alphare added a subscriber: Alphare.

Thanks

This revision is now accepted and ready to land.Oct 29 2021, 9:34 AM
marmoute added a commit: rHGaad84024660f: pull: make the new argument a keyword argument.Oct 29 2021, 9:51 AM
Closed by commit rHGaad84024660f: pull: make the new argument a keyword argument (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.
danchr added a subscriber: danchr.Oct 30 2021, 7:19 AM

This made the compatibility fix much simpler, thank you!

Revision Contents
Changeset List

PathPackages
Mmercurial/exchange.py (2 lines)

Diff 31009

mercurial/exchange.py

A new should be created at the beginning of each pull and discarded A new should be created at the beginning of each pull and discarded
afterward. afterward.
""" """
def __init__( def __init__(
self, self,
repo, repo,
remote, remote,
path,
heads=None, heads=None,
force=False, force=False,
bookmarks=(), bookmarks=(),
remotebookmarks=None, remotebookmarks=None,
streamclonerequested=None, streamclonerequested=None,
includepats=None, includepats=None,
excludepats=None, excludepats=None,
depth=None, depth=None,
path=None,
): ):
# repo we pull into # repo we pull into
self.repo = repo self.repo = repo
# repo we pull from # repo we pull from
self.remote = remote self.remote = remote
# path object used to build this remote # path object used to build this remote
# #
# Ideally, the remote peer would carry that directly. # Ideally, the remote peer would carry that directly.