This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11741

tests: accept alternative privileged port allocation failure
ClosedPublic

Authored by Alphare on Nov 9 2021, 8:18 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG6f43569729d4: tests: accept alternative privileged port allocation failure
rHG4cfb1202aeab: tests: accept alternative privileged port allocation failure
Summary

This registers an additional failure message on failed privileged port
allocation, equally funcionally valid but previously not handled and causing
the test to fail when run in the NixOS sandbox.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Nov 9 2021, 8:18 AM
pacien added a subscriber: pacien.Nov 9 2021, 8:32 AM
pacien added a commit: rHG4cfb1202aeab: tests: accept alternative privileged port allocation failure.Nov 9 2021, 9:30 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG4cfb1202aeab: tests: accept alternative privileged port allocation failure (authored by pacien). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-serve.t (1 line)

Diff 31038

tests/test-serve.t

# On some others the kernel is configured to allow any user to bind them and # On some others the kernel is configured to allow any user to bind them and
# this will work fine # this will work fine
#if no-windows #if no-windows
$ KILLQUIETLY=Y $ KILLQUIETLY=Y
$ hgserve -p daytime $ hgserve -p daytime
abort: cannot start server at 'localhost:13': Permission denied (?) abort: cannot start server at 'localhost:13': Permission denied (?)
abort: child process failed to start (?) abort: child process failed to start (?)
abort: no port number associated with service 'daytime' (?)
listening at http://localhost/ (bound to $LOCALIP:13) (?) listening at http://localhost/ (bound to $LOCALIP:13) (?)
% errors % errors
$ KILLQUIETLY=N $ KILLQUIETLY=N
#endif #endif
With --prefix foo With --prefix foo
$ hgserve --prefix foo $ hgserve --prefix foo