This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11741

tests: accept alternative privileged port allocation failure
ClosedPublic

Authored by Alphare on Nov 9 2021, 8:18 AM.

Download Raw Diff

Details

Reviewers

None

Group Reviewers

hg-reviewers

Commits

rHG6f43569729d4: tests: accept alternative privileged port allocation failure
rHG4cfb1202aeab: tests: accept alternative privileged port allocation failure

Summary

This registers an additional failure message on failed privileged port
allocation, equally funcionally valid but previously not handled and causing
the test to fail when run in the NixOS sandbox.

Diff Detail

Repository

rHG Mercurial

Branch

stable

Lint

No Linters Available

Unit

No Unit Test Coverage

Event Timeline

Alphare created this revision.Nov 9 2021, 8:18 AM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptNov 9 2021, 8:18 AM

Herald added a subscriber: mercurial-patches. · View Herald Transcript

pacien added a subscriber: pacien.Nov 9 2021, 8:32 AM

pacien added a commit: rHG4cfb1202aeab: tests: accept alternative privileged port allocation failure.Nov 9 2021, 9:30 AM

This revision was not accepted when it landed; it landed in state Needs Review.

Closed by commit rHG4cfb1202aeab: tests: accept alternative privileged port allocation failure (authored by pacien). · Explain Why

This revision was automatically updated to reflect the committed changes.

pacien added a commit: rHG6f43569729d4: tests: accept alternative privileged port allocation failure.Nov 9 2021, 10:51 AM

Revision Contents
Changeset List

			Path	Packages
M			tests/test-serve.t (1 line)

Commit	Parents	Author	Summary	Date
5380570453b2	ba6959d82c44	pacien		Nov 8 2021, 8:19 PM

Status	Author	Revision
Closed	Alphare	D11741 tests: accept alternative privileged port allocation failure
Closed	Alphare	D11740 tests: allow the true command to be provided by coreutils
Closed	Alphare	D11739 tests: add guard check for suid support
Closed	Alphare	D11738 tests: run the whole hg-core/path_auditor test in a clean temp dir

Diff 31033

tests/test-serve.t

	# On some others the kernel is configured to allow any user to bind them and			# On some others the kernel is configured to allow any user to bind them and
	# this will work fine			# this will work fine

	#if no-windows			#if no-windows
	$ KILLQUIETLY=Y			$ KILLQUIETLY=Y
	$ hgserve -p daytime			$ hgserve -p daytime
	abort: cannot start server at 'localhost:13': Permission denied (?)			abort: cannot start server at 'localhost:13': Permission denied (?)
	abort: child process failed to start (?)			abort: child process failed to start (?)
				abort: no port number associated with service 'daytime' (?)
	listening at http://localhost/ (bound to $LOCALIP:13) (?)			listening at http://localhost/ (bound to $LOCALIP:13) (?)
	% errors			% errors
	$ KILLQUIETLY=N			$ KILLQUIETLY=N
	#endif			#endif

	With --prefix foo			With --prefix foo

	$ hgserve --prefix foo			$ hgserve --prefix foo

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	31033		Nov 9 2021, 8:18 AM	★	★
Diff 2	31038	rHG4cfb1202aeab4beab58b3621b0bcb645b5dae014	Nov 8 2021, 8:19 PM	★	★