( )⚙ D11763 cext: define S_IFLNK on Python 2.7 and Windows

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11763

cext: define S_IFLNK on Python 2.7 and Windows
ClosedPublic

Authored by indygreg on Nov 15 2021, 10:54 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG3620ab28882d: cext: define S_IFLNK on Python 2.7 and Windows
Summary

Before this change, building on Python 2.7 on Windows fails due to
S_IFLNK being undefined. This regression was introduced by
a32a96079e2d / D11518.

It worked on Python 3 because its pyport.h (which is included via
Python.h) contains effectively the same code as added by this
changeset.

Diff Detail

Repository
rHG Mercurial
Branch
stable
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

indygreg created this revision.Nov 15 2021, 10:54 PM
indygreg added a commit: rHG3620ab28882d: cext: define S_IFLNK on Python 2.7 and Windows.Nov 16 2021, 1:23 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG3620ab28882d: cext: define S_IFLNK on Python 2.7 and Windows (authored by indygreg). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/cext/parsers.c (6 lines)

Diff 31077

mercurial/cext/parsers.c

#ifdef IS_PY3K #ifdef IS_PY3K
/* The mapping of Python types is meant to be temporary to get Python /* The mapping of Python types is meant to be temporary to get Python
* 3 to compile. We should remove this once Python 3 support is fully * 3 to compile. We should remove this once Python 3 support is fully
* supported and proper types are used in the extensions themselves. */ * supported and proper types are used in the extensions themselves. */
#define PyInt_Check PyLong_Check #define PyInt_Check PyLong_Check
#define PyInt_FromLong PyLong_FromLong #define PyInt_FromLong PyLong_FromLong
#define PyInt_FromSsize_t PyLong_FromSsize_t #define PyInt_FromSsize_t PyLong_FromSsize_t
#define PyInt_AsLong PyLong_AsLong #define PyInt_AsLong PyLong_AsLong
#else
/* Windows on Python 2.7 doesn't define S_IFLNK. Python 3+ defines via
* pyport.h. */
#ifndef S_IFLNK
#define S_IFLNK 0120000
#endif
#endif #endif
static const char *const versionerrortext = "Python minor version mismatch"; static const char *const versionerrortext = "Python minor version mismatch";
static const int dirstate_v1_from_p2 = -2; static const int dirstate_v1_from_p2 = -2;
static const int dirstate_v1_nonnormal = -1; static const int dirstate_v1_nonnormal = -1;
static const int ambiguous_time = -1; static const int ambiguous_time = -1;