Page MenuHomePhabricator

dirstate-v2: initial Python parser
ClosedPublic

Authored by SimonSapin on Fri, Oct 1, 3:18 AM.

Details

Summary

The dirstate-v2 file format should be supported even if Rust extensions are
not enabled. This changeset adds parsing code that is not used yet.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

SimonSapin created this revision.Fri, Oct 1, 3:18 AM
marmoute requested changes to this revision.Fri, Oct 1, 4:55 AM
marmoute added a subscriber: marmoute.

This change is actually quite simple to read. I could use a couple of doc-string though. Given the "unrelated" change issue to I am marking it as "Request-Changes", but the logic looks solid.

rust/hg-core/src/dirstate_tree/on_disk.rs
26–119

This change to the Rust code seems "unrelated"¹ and should go in a different patch, should they not ?

[1] i.e. they can be made independently on their own before this patch and still make sense.

This revision now requires changes to proceed.Fri, Oct 1, 4:55 AM
marmoute retitled this revision from dirstate-v2: Initial Python parser to dirstate-v2: initial Python parser.
marmoute updated this revision to Diff 30499.
marmoute updated this revision to Diff 30615.Sun, Oct 3, 7:45 AM
marmoute updated this revision to Diff 30620.Sun, Oct 3, 7:51 AM
Alphare accepted this revision.Sun, Oct 3, 5:22 PM
SimonSapin updated this revision to Diff 30689.Fri, Oct 8, 12:01 PM
baymax updated this revision to Diff 30759.Tue, Oct 12, 2:03 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

SimonSapin updated this revision to Diff 30774.Wed, Oct 13, 1:24 PM
pulkit accepted this revision.Wed, Oct 13, 3:16 PM
pulkit accepted this revision.
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.