Page MenuHomePhabricator

dirstate-v2: Initial Python serializer
ClosedPublic

Authored by SimonSapin on Fri, Oct 1, 3:18 AM.

Details

Summary

This adds code seralizing a map and copy_map dicts into dirstate-v2
file formate. This is not used yet.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

SimonSapin created this revision.Fri, Oct 1, 3:18 AM

This patch was originally authored by Raphaël Gomès and includes some edits by me

marmoute accepted this revision.Fri, Oct 1, 5:23 AM
marmoute added a subscriber: marmoute.

Looks good, with a couple of nits.

mercurial/dirstateutils/v2.py
91

This should go in the previous changesets.

264–272

This block should go in the if len(map) ==0: block

306

This probably deserve that we check any_tracked¹ here.

[1] introduced in a parallel series

314

can probably be a < for clarity.

marmoute updated this revision to Diff 30500.Fri, Oct 1, 9:51 AM
marmoute updated this revision to Diff 30616.Sun, Oct 3, 7:46 AM
Alphare added a subscriber: Alphare.Sun, Oct 3, 5:23 PM

I've written most of this, so I cannot queue it, but the changes on top of mine look good.

SimonSapin updated this revision to Diff 30687.Fri, Oct 8, 8:06 AM
SimonSapin updated this revision to Diff 30690.Fri, Oct 8, 12:01 PM
baymax updated this revision to Diff 30760.Tue, Oct 12, 2:04 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

SimonSapin updated this revision to Diff 30775.Wed, Oct 13, 1:25 PM
pulkit accepted this revision.Wed, Oct 13, 3:15 PM
This revision is now accepted and ready to land.Wed, Oct 13, 3:15 PM
This revision was automatically updated to reflect the committed changes.