This is an archive of the discontinued Mercurial Phabricator instance.

mercurial: use io.BytesIO instead of util.stringio
Needs RevisionPublic

Authored by indygreg on Mar 9 2022, 8:07 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Summary

util.stringio is an alias to io.BytesIO. Let's just use io.BytesIO
directly.

I'm doing this because I noticed pytype was confused about types due to
the indirection.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

indygreg created this revision.Mar 9 2022, 8:07 PM
Alphare requested changes to this revision.Mar 14 2022, 6:23 AM
Alphare added a subscriber: Alphare.
Alphare added inline comments.
mercurial/patch.py
601

This is unrelated and will probably break the current version of the CI (now that I think of it, I was supposed to figure out how to properly fix this annoyance last week and got sidetracked. I'll try to get to it this week.)

This revision now requires changes to proceed.Mar 14 2022, 6:23 AM