This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12512

rust-dirstatemap: remove `settitem`
Needs ReviewPublic

Authored by Alphare on Tue, Apr 12, 12:03 PM.

Download Raw Diff

Details

Reviewers

None

Group Reviewers

hg-reviewers

Summary

This is not used anywhere now.

Diff Detail

Repository

rHG Mercurial

Branch

default

Lint

No Linters Available

Unit

No Unit Test Coverage

Event Timeline

Alphare created this revision.Tue, Apr 12, 12:03 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptTue, Apr 12, 12:03 PM

Herald added a subscriber: mercurial-patches. · View Herald Transcript

Alphare added a child revision: D12513: rust-dirstatemap: remove `_drop_entry`.Tue, Apr 12, 12:03 PM

Revision Contents
Changeset List

			Path	Packages
M			mercurial/dirstatemap.py (4 lines)

Commit	Parents	Author	Summary	Date
237b8556695c	b25e44ebd914	Raphaël Gomès		Mon, Mar 28, 5:34 PM

Status	Author	Revision
Needs Review	Alphare	D12541 rust-dirstatemap: remove unused helper from the old API
Needs Review	Alphare	D12540 rust-status: stop using `state()` in the dispatch logic
Needs Review	Alphare	D12539 rust-status: stop using `state()` in `handle_normal_file`
Needs Review	Alphare	D12538 rust-dirstatemap: stop using `state()` in the cache logic
Needs Review	Alphare	D12537 rust-dirstatemap: stop using `.state` in `is_from_other_parent`
Needs Review	Alphare	D12536 rust-dirstate-entry: add `modified` method
Needs Review	Alphare	D12535 rust: remove use of `EntryState` in `DirsMultiset`
Needs Review	Alphare	D12534 rust: use `entry.tracked()` directly
Needs Review	Alphare	D12533 rust-hg-cpython: remove use of `EntryState`
Needs Review	Alphare	D12532 rust-dirstatemap: use a checked sub instead of a potentially underflowing one
Needs Review	Alphare	D12531 rust-dirstatemap: add simpler version of `get_node_mut`
Needs Review	Alphare	D12530 rust-dirstatemap: use `get_node_mut` instead or `get_or_insert_node`
Needs Review	Alphare	D12529 rust-dirstatemap: add `each_ancestor` argument to `get_node_mut`
Needs Review	Alphare	D12528 rust-dirstatemap: add simpler method `get_or_insert_node` for the common case
Needs Review	Alphare	D12527 rust-dirstatemap: inline the last `get_or_insert` call
Needs Review	Alphare	D12526 rust-dirstatemap: add `set_cached_mtime` helper method
Needs Review	Alphare	D12525 rust-dirstatemap: add `clear_cached_mtime` helper method
Needs Review	Alphare	D12524 rust-dirstatemap: add unit tests
Needs Review	Alphare	D12523 rust: add `Debug` trait to a bunch of structs
Needs Review	Alphare	D12522 rust-dirstatemap: use `&HgPath` instead of `HgPathBuf` in `copy_map_insert`
Needs Review	Alphare	D12521 rust-dirstatemap: use `DirstateEntry::tracked` directly
Needs Review	Alphare	D12520 rust-cpython: remove unused API to `drop_entry_and_copy_source`
Needs Review	Alphare	D12519 rust-dirstatemap: remove `set_dirstate_entry`/`set_entry` methods
Needs Review	Alphare	D12518 rust-dirstatemap: implement part of the `setparents` logic
Needs Review	Alphare	D12517 dirstate-item: add missing bit of docstring
Needs Review	Alphare	D12516 dirstatemap: move `_dirs_incr` and `_dirs_decr` methods out of the common
Needs Review	Alphare	D12515 dirstatemap: move `_refresh_entry` out of the common methods
Needs Review	Alphare	D12514 dirstatemap: move `_drop_entry` out of the common methods
Needs Review	Alphare	D12513 rust-dirstatemap: remove `_drop_entry`
Needs Review	Alphare	D12512 rust-dirstatemap: remove `__settitem__`
Needs Review	Alphare	D12511 rust-dirstatemap: remove unused `_refresh_entry` implementation
Needs Review	Alphare	D12510 rust-distatemap: remove `addfile` API
Needs Review	Alphare	D12509 rust-dirstatemap: remove `removefile` API
Needs Review	Alphare	D12508 rhg: use the new `set_clean` API
Needs Review	Alphare	D12507 dirstatemap: move `set_untracked` out of the common methods
Needs Review	Alphare	D12506 rust-dirstatemap: add `set_untracked` method
Needs Review	Alphare	D12505 dirstatemap: move `set_possibly_dirty` out of the common methods
Needs Review	Alphare	D12504 rust-dirstatemap: add `set_possibly_dirty` method
Needs Review	Alphare	D12503 dirstatemap: move `set_clean` out of common methods
Needs Review	Alphare	D12502 rust-dirstatemap: add `set_clean` method
Needs Review	Alphare	D12501 dirstatemap: remove `_insert_entry`
Needs Review	Alphare	D12500 dirstatemap: move `reset_state` out of common methods
Needs Review	Alphare	D12499 rust-dirstatemap: add Rust implementation of `reset_state`
Needs Review	Alphare	D12498 rust-dirstate: introduce intermediate struct for dirstate-v2 data
Needs Review	Alphare	D12497 dirstatemap: remove unused parameter from `reset_state`
Needs Review	Alphare	D12496 dirstatemap: move `set_tracked` out of common methods and plug in Rust
Needs Review	Alphare	D12495 rust-dirstatemap: add `set_tracked` method

Diff 33075

mercurial/dirstatemap.py

	p1_tracked,			p1_tracked,
	p2_info,			p2_info,
	has_meaningful_mtime,			has_meaningful_mtime,
	parentfiledata,			parentfiledata,
	)			)

	def _drop_entry(self, f):			def _drop_entry(self, f):
	self._map.drop_item_and_copy_source(f)			self._map.drop_item_and_copy_source(f)

	def __setitem__(self, key, value):
	assert isinstance(value, DirstateItem)
	self._map.set_dirstate_item(key, value)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	33075			Tue, Apr 12, 12:03 PM	★	★