This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11547

dirstate-v2: Name a constant in the Rust implementation
ClosedPublic

Authored by marmoute on Oct 1 2021, 9:51 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG47fabca85457: dirstate-v2: Name a constant in the Rust implementation
Summary

We are about to introduce a Python version of this code that will also need
this constant.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Oct 1 2021, 9:51 AM
Alphare accepted this revision.Oct 1 2021, 1:05 PM
This revision is now accepted and ready to land.Oct 1 2021, 1:05 PM
SimonSapin edited parent revisions, added: D11620: dirstate-v2: Swap the order of size and mtime on disk; removed: D11546: dirstate-v2: Add internal documentation.Oct 8 2021, 8:06 AM
SimonSapin retitled this revision from dirstate-v2: minor cleanup to the rust implementation to dirstate-v2: Name a constant in the Rust implementation.
SimonSapin edited the summary of this revision. (Show Details)
SimonSapin added a child revision: D11621: dirstate: Move more methods to the _dirstatemapcommon base class.
SimonSapin removed a child revision: D11518: dirstate-v2: initial Python parser.
SimonSapin updated this revision to Diff 30684.
baymax updated this revision to Diff 30757.Oct 12 2021, 2:03 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Revision Contents
Changeset List

Diff 30762

rust/hg-core/src/dirstate_tree/on_disk.rs

pub(super) const IGNORE_PATTERNS_HASH_LEN: usize = 20; pub(super) const IGNORE_PATTERNS_HASH_LEN: usize = 20;
pub(super) type IgnorePatternsHash = [u8; IGNORE_PATTERNS_HASH_LEN]; pub(super) type IgnorePatternsHash = [u8; IGNORE_PATTERNS_HASH_LEN];
/// Must match the constant of the same name in /// Must match the constant of the same name in
/// `mercurial/dirstateutils/docket.py` /// `mercurial/dirstateutils/docket.py`
const TREE_METADATA_SIZE: usize = 44; const TREE_METADATA_SIZE: usize = 44;
const NODE_SIZE: usize = 43;
/// Make sure that size-affecting changes are made knowingly /// Make sure that size-affecting changes are made knowingly
#[allow(unused)] #[allow(unused)]
fn static_assert_size_of() { fn static_assert_size_of() {
let _ = std::mem::transmute::<TreeMetadata, [u8; TREE_METADATA_SIZE]>; let _ = std::mem::transmute::<TreeMetadata, [u8; TREE_METADATA_SIZE]>;
let _ = std::mem::transmute::<DocketHeader, [u8; TREE_METADATA_SIZE + 81]>; let _ = std::mem::transmute::<DocketHeader, [u8; TREE_METADATA_SIZE + 81]>;
let _ = std::mem::transmute::<Node, [u8; 43]>; let _ = std::mem::transmute::<Node, [u8; NODE_SIZE]>;
} }
// Must match `HEADER` in `mercurial/dirstateutils/docket.py` // Must match `HEADER` in `mercurial/dirstateutils/docket.py`
#[derive(BytesCast)] #[derive(BytesCast)]
#[repr(C)] #[repr(C)]
struct DocketHeader { struct DocketHeader {
marker: [u8; V2_FORMAT_MARKER.len()], marker: [u8; V2_FORMAT_MARKER.len()],
parent_1: [u8; STORED_NODE_ID_BYTES], parent_1: [u8; STORED_NODE_ID_BYTES],