( )⚙ D1176 fsmonitor: declare missing config options

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1176

fsmonitor: declare missing config options
ClosedPublic

Authored by indygreg on Oct 18 2017, 4:58 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHGdbb542326582: fsmonitor: declare missing config options
rHG25dcc8102deb: fsmonitor: declare missing config options
Summary

These were added in 4aa57627692a. Attempting to run the test harness
with fsmonitor enabled spews a whole bunch of devel warnings due to
these options not be declared.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Oct 18 2017, 4:58 PM
durin42 accepted this revision.Oct 18 2017, 5:03 PM
This revision is now accepted and ready to land.Oct 18 2017, 5:03 PM
Closed by commit rHG25dcc8102deb: fsmonitor: declare missing config options (authored by indygreg). · Explain WhyOct 18 2017, 5:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/fsmonitor/__init__.py (6 lines)

Diff 2997

hgext/fsmonitor/__init__.py

default=False, default=False,
) )
configitem('fsmonitor', 'timeout', configitem('fsmonitor', 'timeout',
default='2', default='2',
) )
configitem('fsmonitor', 'blacklistusers', configitem('fsmonitor', 'blacklistusers',
default=list, default=list,
) )
configitem('experimental', 'fsmonitor.transaction_notify',
default=False,
)
configitem('experimental', 'fsmonitor.wc_change_notify',
default=False,
)
# This extension is incompatible with the following blacklisted extensions # This extension is incompatible with the following blacklisted extensions
# and will disable itself when encountering one of these: # and will disable itself when encountering one of these:
_blacklist = ['largefiles', 'eol'] _blacklist = ['largefiles', 'eol']
def _handleunavailable(ui, state, ex): def _handleunavailable(ui, state, ex):
"""Exception handler for Watchman interaction exceptions""" """Exception handler for Watchman interaction exceptions"""
if isinstance(ex, watchmanclient.Unavailable): if isinstance(ex, watchmanclient.Unavailable):