( )⚙ D1177 chgserver: do not treat HG as sensitive environ when CHGHG is set

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1177

chgserver: do not treat HG as sensitive environ when CHGHG is set
ClosedPublic

Authored by quark on Oct 18 2017, 5:57 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG7bf7544fd6cc: chgserver: do not treat HG as sensitive environ when CHGHG is set
rHGc5150f6b8268: chgserver: do not treat HG as sensitive environ when CHGHG is set
Summary

When $CHGHG is set, $HG is ignored by the chg client. Removing it from
chg's sensitive environment list would avoid starting up servers
unnecessarily when $CHGHG is the same while $HG is different.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

quark created this revision.Oct 18 2017, 5:57 PM
durin42 accepted this revision.Oct 18 2017, 5:58 PM
This revision is now accepted and ready to land.Oct 18 2017, 5:58 PM
Closed by commit rHGc5150f6b8268: chgserver: do not treat HG as sensitive environ when CHGHG is set (authored by quark). · Explain WhyOct 18 2017, 5:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/chgserver.py (7 lines)

Diff 3001

mercurial/chgserver.py

same time. same time.
""" """
sectionitems = [] sectionitems = []
for section in _configsections: for section in _configsections:
sectionitems.append(ui.configitems(section)) sectionitems.append(ui.configitems(section))
for section, item in _configsectionitems: for section, item in _configsectionitems:
sectionitems.append(ui.config(section, item)) sectionitems.append(ui.config(section, item))
sectionhash = _hashlist(sectionitems) sectionhash = _hashlist(sectionitems)
# If $CHGHG is set, the change to $HG should not trigger a new chg server
if 'CHGHG' in encoding.environ:
ignored = {'HG'}
else:
ignored = set()
envitems = [(k, v) for k, v in encoding.environ.iteritems() envitems = [(k, v) for k, v in encoding.environ.iteritems()
if _envre.match(k)] if _envre.match(k) and k not in ignored]
envhash = _hashlist(sorted(envitems)) envhash = _hashlist(sorted(envitems))
return sectionhash[:6] + envhash[:6] return sectionhash[:6] + envhash[:6]
def _getmtimepaths(ui): def _getmtimepaths(ui):
"""get a list of paths that should be checked to detect change """get a list of paths that should be checked to detect change
The list will include: The list will include:
- extensions (will not cover all files for complex extensions) - extensions (will not cover all files for complex extensions)