This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11806

downgrade: don't assume existence of nodemap files when downgrading
ClosedPublic

Authored by Alphare on Nov 25 2021, 12:27 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG897aa0c4da4a: downgrade: don't assume existence of nodemap files when downgrading
Summary

Persistent nodemap files might not exist on a fresh repository, so ignore the
potential missing file errors.

Diff Detail

Repository
rHG Mercurial
Branch
stable
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Alphare created this revision.Nov 25 2021, 12:27 PM
pulkit accepted this revision.Nov 28 2021, 5:08 PM
This revision is now accepted and ready to land.Nov 28 2021, 5:08 PM

Revision Contents
Changeset List

PathPackages
Mmercurial/revlogutils/nodemap.py (2 lines)

Diff 31130

mercurial/revlogutils/nodemap.py

notr._postclose[k](None) notr._postclose[k](None)
def delete_nodemap(tr, repo, revlog): def delete_nodemap(tr, repo, revlog):
"""Delete nodemap data on disk for a given revlog""" """Delete nodemap data on disk for a given revlog"""
if revlog._nodemap_file is None: if revlog._nodemap_file is None:
msg = "calling persist nodemap on a revlog without the feature enabled" msg = "calling persist nodemap on a revlog without the feature enabled"
raise error.ProgrammingError(msg) raise error.ProgrammingError(msg)
repo.svfs.unlink(revlog._nodemap_file) repo.svfs.tryunlink(revlog._nodemap_file)
def persist_nodemap(tr, revlog, pending=False, force=False): def persist_nodemap(tr, revlog, pending=False, force=False):
"""Write nodemap data on disk for a given revlog""" """Write nodemap data on disk for a given revlog"""
if getattr(revlog, 'filteredrevs', ()): if getattr(revlog, 'filteredrevs', ()):
raise error.ProgrammingError( raise error.ProgrammingError(
"cannot persist nodemap of a filtered changelog" "cannot persist nodemap of a filtered changelog"
) )