Page MenuHomePhabricator

extensions: highlight the name of the faulty extensions in the error message
ClosedPublic

Authored by marmoute on Nov 29 2021, 11:51 AM.

Details

Summary

This make it easier to understand the message when the extensions name is
common.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Nov 29 2021, 11:51 AM
Alphare requested changes to this revision.Nov 30 2021, 9:33 AM
Alphare added a subscriber: Alphare.

Mhhh I might be picky but we should be using single quotes here, not double.

This revision now requires changes to proceed.Nov 30 2021, 9:33 AM

Mhhh I might be picky but we should be using single quotes here, not double.

why ? double quote seems a better fit to quote a world in an actual file.

Alphare accepted this revision.Nov 30 2021, 9:40 AM

I misremembered UK vs US quoting. Turns out you're right (and it didn't really matter)

This revision is now accepted and ready to land.Nov 30 2021, 9:40 AM