This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11891

share: move the requirement initialisation code around
ClosedPublic

Authored by marmoute on Dec 10 2021, 5:35 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG7964a2dbde12: share: move the requirement initialisation code around
Summary

We will make this logic more flexible in the next patch. We start by moving it
at the end of the function without any other change for clarity.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/localrepo.py (21 lines)

Diff 31461

mercurial/localrepo.py

def newreporequirements(ui, createopts): def newreporequirements(ui, createopts):
"""Determine the set of requirements for a new local repository. """Determine the set of requirements for a new local repository.
Extensions can wrap this function to specify custom requirements for Extensions can wrap this function to specify custom requirements for
new repositories. new repositories.
""" """
# If the repo is being created from a shared repository, we copy
# its requirements.
if b'sharedrepo' in createopts:
requirements = set(createopts[b'sharedrepo'].requirements)
if createopts.get(b'sharedrelative'):
requirements.add(requirementsmod.RELATIVE_SHARED_REQUIREMENT)
else:
requirements.add(requirementsmod.SHARED_REQUIREMENT)
return requirements
if b'backend' not in createopts: if b'backend' not in createopts:
raise error.ProgrammingError( raise error.ProgrammingError(
b'backend key not present in createopts; ' b'backend key not present in createopts; '
b'was defaultcreateopts() called?' b'was defaultcreateopts() called?'
) )
if createopts[b'backend'] != b'revlogv1': if createopts[b'backend'] != b'revlogv1':
if ui.configbool(b'format', b'use-persistent-nodemap'): if ui.configbool(b'format', b'use-persistent-nodemap'):
requirements.add(requirementsmod.NODEMAP_REQUIREMENT) requirements.add(requirementsmod.NODEMAP_REQUIREMENT)
# if share-safe is enabled, let's create the new repository with the new # if share-safe is enabled, let's create the new repository with the new
# requirement # requirement
if ui.configbool(b'format', b'use-share-safe'): if ui.configbool(b'format', b'use-share-safe'):
requirements.add(requirementsmod.SHARESAFE_REQUIREMENT) requirements.add(requirementsmod.SHARESAFE_REQUIREMENT)
# If the repo is being created from a shared repository, we copy
# its requirements.
if b'sharedrepo' in createopts:
requirements = set(createopts[b'sharedrepo'].requirements)
if createopts.get(b'sharedrelative'):
requirements.add(requirementsmod.RELATIVE_SHARED_REQUIREMENT)
else:
requirements.add(requirementsmod.SHARED_REQUIREMENT)
return requirements
return requirements return requirements
def checkrequirementscompat(ui, requirements): def checkrequirementscompat(ui, requirements):
"""Checks compatibility of repository requirements enabled and disabled. """Checks compatibility of repository requirements enabled and disabled.
Returns a set of requirements which needs to be dropped because dependend Returns a set of requirements which needs to be dropped because dependend
requirements are not enabled. Also warns users about it""" requirements are not enabled. Also warns users about it"""