( )⚙ D11906 hghave: fix the check for suid on platforms lacking support

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11906

hghave: fix the check for suid on platforms lacking support
ClosedPublic

Authored by mharbison72 on Dec 13 2021, 1:11 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGf21e7748c257: hghave: fix the check for suid on platforms lacking support
Summary

The mac tests were raising an AttributeError without the default arg.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Dec 13 2021, 1:11 AM
Alphare accepted this revision.Dec 13 2021, 6:12 AM
This revision is now accepted and ready to land.Dec 13 2021, 6:12 AM

Revision Contents
Changeset List

PathPackages
Mtests/hghave.py (5 lines)

Diff 31443

tests/hghave.py

except (IOError, OSError): except (IOError, OSError):
# we don't care, the user probably won't be able to commit anyway # we don't care, the user probably won't be able to commit anyway
return False return False
return not (new_file_has_exec or exec_flags_cannot_flip) return not (new_file_has_exec or exec_flags_cannot_flip)
@check("suidbit", "setuid and setgid bit") @check("suidbit", "setuid and setgid bit")
def has_suidbit(): def has_suidbit():
if getattr(os, "statvfs", None) is None or getattr(os, "ST_NOSUID") is None: if (
getattr(os, "statvfs", None) is None
or getattr(os, "ST_NOSUID", None) is None
):
return False return False
return bool(os.statvfs('.').f_flag & os.ST_NOSUID) return bool(os.statvfs('.').f_flag & os.ST_NOSUID)
@check("icasefs", "case insensitive file system") @check("icasefs", "case insensitive file system")
def has_icasefs(): def has_icasefs():
# Stolen from mercurial.util # Stolen from mercurial.util
fd, path = tempfile.mkstemp(dir='.', prefix=tempprefix) fd, path = tempfile.mkstemp(dir='.', prefix=tempprefix)