This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12122

dirstate: use a context manager when writing the dirstate
ClosedPublic

Authored by marmoute on Jan 31 2022, 10:30 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGcdb0d857afe2: dirstate: use a context manager when writing the dirstate
Summary

This make sure the file is closed in a timely manner.

We define a lambda for the file opening. It might seems a bit overkill here but
a future changeset will need to do more of those.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jan 31 2022, 10:30 AM
Alphare accepted this revision.Feb 3 2022, 4:56 AM
This revision is now accepted and ready to land.Feb 3 2022, 4:56 AM

Revision Contents
Changeset List

PathPackages
Mmercurial/dirstate.py (5 lines)

Diff 32040

mercurial/dirstate.py

tr.addfilegenerator( tr.addfilegenerator(
b'dirstate', b'dirstate',
(self._filename,), (self._filename,),
lambda f: self._writedirstate(tr, f), lambda f: self._writedirstate(tr, f),
location=b'plain', location=b'plain',
) )
return return
st = self._opener(filename, b"w", atomictemp=True, checkambig=True) file = lambda f: self._opener(f, b"w", atomictemp=True, checkambig=True)
self._writedirstate(tr, st) with file(self._filename) as f:
self._writedirstate(tr, f)
def addparentchangecallback(self, category, callback): def addparentchangecallback(self, category, callback):
"""add a callback to be called when the wd parents are changed """add a callback to be called when the wd parents are changed
Callback will be called with the following arguments: Callback will be called with the following arguments:
dirstate, (oldp1, oldp2), (newp1, newp2) dirstate, (oldp1, oldp2), (newp1, newp2)
Category is a unique identifier to allow overwriting an old callback Category is a unique identifier to allow overwriting an old callback