( )⚙ D12126 branchmap: Add a test about writing branchmap and aborted transaction

This is an archive of the discontinued Mercurial Phabricator instance.

branchmap: Add a test about writing branchmap and aborted transaction
ClosedPublic

Authored by marmoute on Feb 1 2022, 11:51 AM.

Details

Summary

It turn out that we update the branchmap on disk whenever we recompute it…
including in a middle of a transaction. This means writing the new branchmap too
early (the changeset are not visible yet) and worse… it mean writing branchmap
for transaction we rollback.

so we introduce a test to highlight the issue (and prevent it to regress in the
future).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Feb 1 2022, 11:51 AM

This series is intended for stable.

Alphare accepted this revision.Feb 2 2022, 4:49 AM
This revision is now accepted and ready to land.Feb 2 2022, 4:49 AM