( )⚙ D12132 automation: use gp3 volume type

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12132

automation: use gp3 volume type
ClosedPublic

Authored by indygreg on Feb 2 2022, 10:11 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG2d6940811067: automation: use gp3 volume type
Summary

This is a newer volume type. It offers a better baseline of performance
by default and is ~10% cheaper. It doesn't offer burst credits. But
its performance is guaranteed, unlike gp2, which had wonky performance
behavior.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

indygreg created this revision.Feb 2 2022, 10:11 PM
Alphare accepted this revision.Feb 16 2022, 5:27 AM
This revision is now accepted and ready to land.Feb 16 2022, 5:27 AM
indygreg added a commit: rHG2d6940811067: automation: use gp3 volume type.Feb 16 2022, 5:31 AM
Closed by commit rHG2d6940811067: automation: use gp3 volume type (authored by indygreg). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 32036

contrib/automation/hgautomation/aws.py

config = { config = {
'BlockDeviceMappings': [ 'BlockDeviceMappings': [
{ {
'DeviceName': image.block_device_mappings[0]['DeviceName'], 'DeviceName': image.block_device_mappings[0]['DeviceName'],
'Ebs': { 'Ebs': {
'DeleteOnTermination': True, 'DeleteOnTermination': True,
'VolumeSize': 10, 'VolumeSize': 10,
'VolumeType': 'gp2', 'VolumeType': 'gp3',
}, },
}, },
], ],
'EbsOptimized': True, 'EbsOptimized': True,
'ImageId': image.id, 'ImageId': image.id,
'InstanceInitiatedShutdownBehavior': 'stop', 'InstanceInitiatedShutdownBehavior': 'stop',
# 8 VCPUs for compiling Python. # 8 VCPUs for compiling Python.
'InstanceType': 't3.2xlarge', 'InstanceType': 't3.2xlarge',
""" """
block_device_mappings = [ block_device_mappings = [
{ {
'DeviceName': image.block_device_mappings[0]['DeviceName'], 'DeviceName': image.block_device_mappings[0]['DeviceName'],
'Ebs': { 'Ebs': {
'DeleteOnTermination': True, 'DeleteOnTermination': True,
'VolumeSize': 12, 'VolumeSize': 12,
'VolumeType': 'gp2', 'VolumeType': 'gp3',
}, },
} }
] ]
# This is not an exhaustive list of instance types having instance storage. # This is not an exhaustive list of instance types having instance storage.
# But # But
if ensure_extra_volume and not instance_type.startswith( if ensure_extra_volume and not instance_type.startswith(
tuple(INSTANCE_TYPES_WITH_STORAGE) tuple(INSTANCE_TYPES_WITH_STORAGE)
) )
block_device_mappings.append( block_device_mappings.append(
{ {
'DeviceName': second_device, 'DeviceName': second_device,
'Ebs': { 'Ebs': {
'DeleteOnTermination': True, 'DeleteOnTermination': True,
'VolumeSize': 8, 'VolumeSize': 8,
'VolumeType': 'gp2', 'VolumeType': 'gp3',
}, },
} }
) )
config = { config = {
'BlockDeviceMappings': block_device_mappings, 'BlockDeviceMappings': block_device_mappings,
'EbsOptimized': True, 'EbsOptimized': True,
'ImageId': image.id, 'ImageId': image.id,
config = { config = {
'BlockDeviceMappings': [ 'BlockDeviceMappings': [
{ {
'DeviceName': '/dev/sda1', 'DeviceName': '/dev/sda1',
'Ebs': { 'Ebs': {
'DeleteOnTermination': True, 'DeleteOnTermination': True,
'VolumeSize': 32, 'VolumeSize': 32,
'VolumeType': 'gp2', 'VolumeType': 'gp3',
}, },
} }
], ],
'ImageId': image.id, 'ImageId': image.id,
'InstanceInitiatedShutdownBehavior': 'stop', 'InstanceInitiatedShutdownBehavior': 'stop',
'InstanceType': 'm6i.large', 'InstanceType': 'm6i.large',
'KeyName': '%sautomation' % prefix, 'KeyName': '%sautomation' % prefix,
'MaxCount': 1, 'MaxCount': 1,
""" """
config = { config = {
'BlockDeviceMappings': [ 'BlockDeviceMappings': [
{ {
'DeviceName': '/dev/sda1', 'DeviceName': '/dev/sda1',
'Ebs': { 'Ebs': {
'DeleteOnTermination': True, 'DeleteOnTermination': True,
'VolumeSize': 32, 'VolumeSize': 32,
'VolumeType': 'gp2', 'VolumeType': 'gp3',
}, },
} }
], ],
'ImageId': image.id, 'ImageId': image.id,
'InstanceInitiatedShutdownBehavior': 'stop', 'InstanceInitiatedShutdownBehavior': 'stop',
'InstanceType': instance_type, 'InstanceType': instance_type,
'KeyName': '%sautomation' % prefix, 'KeyName': '%sautomation' % prefix,
'MaxCount': 1, 'MaxCount': 1,