( )⚙ D12176 revlog: do not compute node location by hand in index_invalidate_added

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12176

revlog: do not compute node location by hand in index_invalidate_added
ClosedPublic

Authored by pacien on Feb 14 2022, 1:06 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGd9a7131648a3: revlog: do not compute node location by hand in index_invalidate_added
Summary

The node is not guaranteed to be at the same location all the time (e.g:
changelog v2), so let's use the official existing API to get that value.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Revision Contents
Changeset List

PathPackages
Mmercurial/cext/revlog.c (6 lines)

Diff 32175

mercurial/cext/revlog.c

{ {
Py_ssize_t i, len; Py_ssize_t i, len;
len = self->length + self->new_length; len = self->length + self->new_length;
i = start - self->length; i = start - self->length;
if (i < 0) if (i < 0)
return; return;
for (i = start; i < len; i++) for (i = start; i < len; i++) {
nt_delete_node(&self->nt, index_deref(self, i) + 32); const char *node = index_node(self, i);
nt_delete_node(&self->nt, node);
}
self->new_length = start - self->length; self->new_length = start - self->length;
} }
/* /*
* Delete a numeric range of revs, which must be at the end of the * Delete a numeric range of revs, which must be at the end of the
* range. * range.
*/ */