This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12185

narrowspec: add timing block for validating narrowspec
ClosedPublic

Authored by durin42 on Feb 15 2022, 2:02 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGeb9c55453249: narrowspec: add timing block for validating narrowspec
Summary

This was showing up in an operation I was doing today, and I'd like to
be able to get trace spans for it instead of just profiler samples.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Feb 15 2022, 2:02 PM
Alphare accepted this revision.Feb 16 2022, 4:27 AM
This revision is now accepted and ready to land.Feb 16 2022, 4:27 AM
durin42 added a commit: rHGeb9c55453249: narrowspec: add timing block for validating narrowspec.Feb 16 2022, 4:59 AM
Closed by commit rHGeb9c55453249: narrowspec: add timing block for validating narrowspec (authored by durin42). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/narrowspec.py (31 lines)

Diff 32239

mercurial/narrowspec.py

And that is a set of normalized patterns beginning with ``path:`` or And that is a set of normalized patterns beginning with ``path:`` or
``rootfilesin:``. ``rootfilesin:``.
This function should be used to validate internal data structures This function should be used to validate internal data structures
and patterns that are loaded from sources that use the internal, and patterns that are loaded from sources that use the internal,
prefixed pattern representation (but can't necessarily be fully trusted). prefixed pattern representation (but can't necessarily be fully trusted).
""" """
with util.timedcm('narrowspec.validatepatterns(pats size=%d)', len(pats)):
if not isinstance(pats, set): if not isinstance(pats, set):
raise error.ProgrammingError( raise error.ProgrammingError(
b'narrow patterns should be a set; got %r' % pats b'narrow patterns should be a set; got %r' % pats
) )
for pat in pats: for pat in pats:
if not pat.startswith(VALID_PREFIXES): if not pat.startswith(VALID_PREFIXES):
# Use a Mercurial exception because this can happen due to user # Use a Mercurial exception because this can happen due to user
# bugs (e.g. manually updating spec file). # bugs (e.g. manually updating spec file).
raise error.Abort( raise error.Abort(
_(b'invalid prefix on narrow pattern: %s') % pat, _(b'invalid prefix on narrow pattern: %s') % pat,
hint=_( hint=_(
b'narrow patterns must begin with one of ' b'narrow patterns must begin with one of '
b'the following: %s' b'the following: %s'
) )
% b', '.join(VALID_PREFIXES), % b', '.join(VALID_PREFIXES),
) )
def format(includes, excludes): def format(includes, excludes):
output = b'[include]\n' output = b'[include]\n'
for i in sorted(includes - excludes): for i in sorted(includes - excludes):
output += i + b'\n' output += i + b'\n'
output += b'[exclude]\n' output += b'[exclude]\n'
for e in sorted(excludes): for e in sorted(excludes):