( )⚙ D12187 filemerge: when using in-memory merge, always put backup files in temp dir

This is an archive of the discontinued Mercurial Phabricator instance.

filemerge: when using in-memory merge, always put backup files in temp dir
ClosedPublic

Authored by martinvonz on Feb 15 2022, 11:09 PM.

Details

Summary

Before calling a merge tool, we create a backup of the local side of
the merge. That file can be put in the working copy or in a temporary
directory, depending on the user's config. When we're merging in
memory, we don't want to write to the actual, on-disk working copy, so
we write the file to the in-memory working copy instead. However,
since we don't support external merge tools with in-memory merge, it
makes no difference where the file is actually stored (and if we ever
do add support for external merge tools, then the file clearly can't
live in the in-memory working-copy object anyway). So, since it
doesn't matter where the file is stored, we can simplify by always
putting them in the system's temp directory.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage