This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12231

cext: unconditionalize PySlice_GetIndicesEx()
ClosedPublic

Authored by indygreg on Mar 1 2022, 7:22 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGacf9f778e048: cext: unconditionalize PySlice_GetIndicesEx()
Summary

We only support Python 3 now.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Mar 1 2022, 7:22 PM
Alphare accepted this revision.Mar 2 2022, 5:18 AM
This revision is now accepted and ready to land.Mar 2 2022, 5:18 AM
indygreg added a commit: rHGacf9f778e048: cext: unconditionalize PySlice_GetIndicesEx().Mar 2 2022, 7:42 AM
Closed by commit rHGacf9f778e048: cext: unconditionalize PySlice_GetIndicesEx() (authored by indygreg). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/cext/revlog.c (6 lines)

Diff 32347

mercurial/cext/revlog.c

* range. * range.
*/ */
static int index_slice_del(indexObject *self, PyObject *item) static int index_slice_del(indexObject *self, PyObject *item)
{ {
Py_ssize_t start, stop, step, slicelength; Py_ssize_t start, stop, step, slicelength;
Py_ssize_t length = index_length(self) + 1; Py_ssize_t length = index_length(self) + 1;
int ret = 0; int ret = 0;
/* Argument changed from PySliceObject* to PyObject* in Python 3. */
#ifdef IS_PY3K
if (PySlice_GetIndicesEx(item, length, &start, &stop, &step, if (PySlice_GetIndicesEx(item, length, &start, &stop, &step,
&slicelength) < 0) &slicelength) < 0)
#else
if (PySlice_GetIndicesEx((PySliceObject *)item, length, &start, &stop,
&step, &slicelength) < 0)
#endif
return -1; return -1;
if (slicelength <= 0) if (slicelength <= 0)
return 0; return 0;
if ((step < 0 && start < stop) || (step > 0 && start > stop)) if ((step < 0 && start < stop) || (step > 0 && start > stop))
stop = start; stop = start;