This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12371

tests: support another error case when detecting ipv4/ipv6 support
ClosedPublic

Authored by spectral on Mar 10 2022, 12:30 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGc194e93d1ebc: tests: support another error case when detecting ipv4/ipv6 support
Summary

I encountered this on Linux in a VM environment with a rather strange networking
setup (both on the host and in the VM).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

spectral created this revision.Mar 10 2022, 12:30 AM
Alphare accepted this revision.Mar 14 2022, 5:15 AM
This revision is now accepted and ready to land.Mar 14 2022, 5:15 AM
Alphare added a comment.Mar 14 2022, 1:40 PM

Looks like this breaks the code formatting tests, and the patch has been published so I can't amend it. Please send a follow-up I can queue

spectral added a comment.Mar 14 2022, 4:34 PM
In D12371#189448, @Alphare wrote:

Looks like this breaks the code formatting tests, and the patch has been published so I can't amend it. Please send a follow-up I can queue

Sorry about that. Send D12375.

Revision Contents
Changeset List

PathPackages
Mtests/run-tests.py (5 lines)

Diff 32629

tests/run-tests.py

family = getattr(socket, name, None) family = getattr(socket, name, None)
if family is None: if family is None:
return False return False
try: try:
s = socket.socket(family, socket.SOCK_STREAM) s = socket.socket(family, socket.SOCK_STREAM)
s.bind(('localhost', port)) s.bind(('localhost', port))
s.close() s.close()
return True return True
except socket.error as exc: except (socket.error, OSError) as exc:
if exc.errno == errno.EADDRINUSE: if exc.errno == errno.EADDRINUSE:
return True return True
elif exc.errno in (errno.EADDRNOTAVAIL, errno.EPROTONOSUPPORT): elif exc.errno in (errno.EADDRNOTAVAIL, errno.EPROTONOSUPPORT,
errno.EAFNOSUPPORT):
return False return False
else: else:
raise raise
else: else:
return False return False
# useipv6 will be set by parseargs # useipv6 will be set by parseargs