( )⚙ D12385 rhg: add support for ignoring all extensions

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12385

rhg: add support for ignoring all extensions
ClosedPublic

Authored by Alphare on Fri, Mar 18, 12:39 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG6b31c0676147: rhg: add support for ignoring all extensions
Summary

Some workflows just want what rhg does and don't care about any extensions,
this makes it easier.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Alphare created this revision.Fri, Mar 18, 12:39 PM
Alphare added a commit: rHG6b31c0676147: rhg: add support for ignoring all extensions.Sat, Mar 19, 1:13 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG6b31c0676147: rhg: add support for ignoring all extensions (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mrust/rhg/src/main.rs (5 lines)
Mtests/test-rhg.t (14 lines)

Diff 32664

rust/rhg/src/main.rs

/// The `*` extension is an edge-case for config sub-options that apply to all /// The `*` extension is an edge-case for config sub-options that apply to all
/// extensions. For now, only `:required` exists, but that may change in the /// extensions. For now, only `:required` exists, but that may change in the
/// future. /// future.
const SUPPORTED_EXTENSIONS: &[&[u8]] = const SUPPORTED_EXTENSIONS: &[&[u8]] =
&[b"blackbox", b"share", b"sparse", b"narrow", b"*"]; &[b"blackbox", b"share", b"sparse", b"narrow", b"*"];
fn check_extensions(config: &Config) -> Result<(), CommandError> { fn check_extensions(config: &Config) -> Result<(), CommandError> {
if let Some(b"*") = config.get(b"rhg", b"ignored-extensions") {
// All extensions are to be ignored, nothing to do here
return Ok(());
}
let enabled: HashSet<&[u8]> = config let enabled: HashSet<&[u8]> = config
.get_section_keys(b"extensions") .get_section_keys(b"extensions")
.into_iter() .into_iter()
.map(|extension| { .map(|extension| {
// Ignore extension suboptions. Only `required` exists for now. // Ignore extension suboptions. Only `required` exists for now.
// `rhg` either supports an extension or doesn't, so it doesn't // `rhg` either supports an extension or doesn't, so it doesn't
// make sense to consider the loading of an extension. // make sense to consider the loading of an extension.
extension.split_2(b':').unwrap_or((extension, b"")).0 extension.split_2(b':').unwrap_or((extension, b"")).0

tests/test-rhg.t

$ echo "[extensions]" >> $HGRCPATH $ echo "[extensions]" >> $HGRCPATH
$ echo "blackbox:required = yes" >> $HGRCPATH $ echo "blackbox:required = yes" >> $HGRCPATH
$ rhg files $ rhg files
a a
$ echo "*:required = yes" >> $HGRCPATH $ echo "*:required = yes" >> $HGRCPATH
$ rhg files $ rhg files
a a
We can ignore all extensions at once
$ echo "[extensions]" >> $HGRCPATH
$ echo "thisextensionbetternotexist=" >> $HGRCPATH
$ echo "thisextensionbetternotexisteither=" >> $HGRCPATH
$ $NO_FALLBACK rhg files
unsupported feature: extensions: thisextensionbetternotexist, thisextensionbetternotexisteither (consider adding them to 'rhg.ignored-extensions' config)
[252]
$ echo "[rhg]" >> $HGRCPATH
$ echo "ignored-extensions=*" >> $HGRCPATH
$ $NO_FALLBACK rhg files
a