( )⚙ D12390 unamend: abort if commit was not created by `hg [un]amend`

This is an archive of the discontinued Mercurial Phabricator instance.

unamend: abort if commit was not created by `hg [un]amend`
ClosedPublic

Authored by martinvonz on Mon, Mar 21, 6:23 PM.

Details

Summary

hg unamend can currently undo any kind of rewrite, as long as it has
an obsmarker. However, that has quite unexpected results if you run it
after e.g. hg rebase (expecting it to behave like a generic `hg
undo` command), because it updates to the predecessor and leaves the
old changes in the working copy. I think it's better to allow `hg
unamend` only after hg amend (and after hg unamend because that's
documented as being supported).

Diff Detail

Repository
rHG Mercurial
Branch
stable
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

martinvonz created this revision.Mon, Mar 21, 6:23 PM

Thank you for your sharing. Recently, I discovered a great website to entertain anywhere. subway surfers

Alphare accepted this revision.Tue, Mar 22, 4:46 AM
This revision is now accepted and ready to land.Tue, Mar 22, 4:46 AM