This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12415

revert: use a `continue` to reduce indentation
ClosedPublic

Authored by martinvonz on Mar 28 2022, 1:57 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG9be7da341885: revert: use a `continue` to reduce indentation
Summary

I'm about to add more code in the block I'm modifying here.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Mar 28 2022, 1:57 PM
Alphare accepted this revision.Apr 6 2022, 6:10 AM
This revision is now accepted and ready to land.Apr 6 2022, 6:10 AM
martinvonz added a commit: rHG9be7da341885: revert: use a `continue` to reduce indentation.Apr 6 2022, 8:51 AM
Closed by commit rHG9be7da341885: revert: use a `continue` to reduce indentation (authored by martinvonz). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/cmdutil.py (10 lines)

Diff 32814

mercurial/cmdutil.py

for f in actions[b'revert'][0]: for f in actions[b'revert'][0]:
prntstatusmsg(b'revert', f) prntstatusmsg(b'revert', f)
checkout(f) checkout(f)
if normal: if normal:
normal(f) normal(f)
for f in actions[b'add'][0]: for f in actions[b'add'][0]:
# Don't checkout modified files, they are already created by the diff # Don't checkout modified files, they are already created by the diff
if f not in newlyaddedandmodifiedfiles: if f in newlyaddedandmodifiedfiles:
continue
prntstatusmsg(b'add', f) prntstatusmsg(b'add', f)
checkout(f) checkout(f)
repo.dirstate.set_tracked(f) repo.dirstate.set_tracked(f)
for f in actions[b'undelete'][0]: for f in actions[b'undelete'][0]:
if interactive: if interactive:
choice = repo.ui.promptchoice( choice = repo.ui.promptchoice(
_(b"add back removed file %s (Yn)?$$ &Yes $$ &No") % f _(b"add back removed file %s (Yn)?$$ &Yes $$ &No") % f
) )
if choice == 0: if choice == 0:
prntstatusmsg(b'undelete', f) prntstatusmsg(b'undelete', f)