This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12423

tests: stop excluding the pycompat module from pyflakes
ClosedPublic

Authored by mharbison72 on Mar 30 2022, 1:46 AM.

Details

Reviewers
marmoute
Group Reviewers
hg-reviewers
Commits
rHG20c6c9e43397: tests: stop excluding the pycompat module from pyflakes
Summary

I assume this was skipped because of all of the py2 stuff causing a lot of spew.
The "unused" imports are left in place in case any 3rd party stuff is using it.
I don't care about most of it, but TortoiseHg uses io and queue, so
minimally I'd like to keep those.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

mharbison72 created this revision.Mar 30 2022, 1:46 AM
marmoute accepted this revision.Mar 31 2022, 5:33 PM
mharbison72 added a commit: rHG20c6c9e43397: tests: stop excluding the pycompat module from pyflakes.Apr 1 2022, 3:41 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG20c6c9e43397: tests: stop excluding the pycompat module from pyflakes (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-check-pyflakes.t (10 lines)

Diff 32737

tests/test-check-pyflakes.t

> EOF > EOF
$ "$PYTHON" -m pyflakes test.py 2>/dev/null | "$TESTDIR/filterpyflakes.py" $ "$PYTHON" -m pyflakes test.py 2>/dev/null | "$TESTDIR/filterpyflakes.py"
test.py:1:* undefined name 'undefinedname' (glob) test.py:1:* undefined name 'undefinedname' (glob)
$ cd "`dirname "$TESTDIR"`" $ cd "`dirname "$TESTDIR"`"
$ testrepohg locate 'set:**.py or grep("^#!.*python")' \ $ testrepohg locate 'set:**.py or grep("^#!.*python")' \
> -X hgext/fsmonitor/pywatchman \ > -X hgext/fsmonitor/pywatchman \
> -X mercurial/pycompat.py -X contrib/python-zstandard \ > -X contrib/python-zstandard \
> -X mercurial/thirdparty \ > -X mercurial/thirdparty \
> 2>/dev/null \ > 2>/dev/null \
> | xargs "$PYTHON" -m pyflakes 2>/dev/null | "$TESTDIR/filterpyflakes.py" > | xargs "$PYTHON" -m pyflakes 2>/dev/null | "$TESTDIR/filterpyflakes.py"
contrib/perf.py:*:* undefined name 'xrange' (glob) (?) contrib/perf.py:*:* undefined name 'xrange' (glob) (?)
mercurial/hgweb/server.py:*:* undefined name 'reload' (glob) (?) mercurial/hgweb/server.py:*:* undefined name 'reload' (glob) (?)
mercurial/pycompat.py:*:* 'codecs' imported but unused (glob)
mercurial/pycompat.py:*:* 'concurrent.futures' imported but unused (glob)
mercurial/pycompat.py:*:* 'http.client as httplib' imported but unused (glob)
mercurial/pycompat.py:*:* 'http.cookiejar as cookielib' imported but unused (glob)
mercurial/pycompat.py:*:* 'io' imported but unused (glob)
mercurial/pycompat.py:*:* 'queue' imported but unused (glob)
mercurial/pycompat.py:*:* 'socketserver' imported but unused (glob)
mercurial/pycompat.py:*:* 'xmlrpc.client as xmlrpclib' imported but unused (glob)
mercurial/util.py:*:* 'pickle' imported but unused (glob) mercurial/util.py:*:* 'pickle' imported but unused (glob)