This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12425

rust-requirements: allow loading repos with `bookmarksinstore` requirement
ClosedPublic

Authored by martinvonz on Apr 1 2022, 2:09 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG81d293eb5264: rust-requirements: allow loading repos with `bookmarksinstore` requirement
Summary

rhg does support bookmarks, so it can load repos with the
bookmarksinstore requirement just as well as other repos.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

martinvonz created this revision.Apr 1 2022, 2:09 AM
Alphare accepted this revision.Apr 1 2022, 5:23 AM
This revision is now accepted and ready to land.Apr 1 2022, 5:23 AM
martinvonz retitled this revision from rhg: allow loading repos with `bookmarksinstore` requirement to rust-requirements: allow loading repos with `bookmarksinstore` requirement.Apr 9 2022, 1:35 AM
martinvonz updated this revision to Diff 33148.Apr 13 2022, 9:10 AM

Revision Contents
Changeset List

PathPackages
Mrust/hg-core/src/requirements.rs (7 lines)

Diff 32739

rust/hg-core/src/requirements.rs

// As of this writing everything rhg does is read-only. // As of this writing everything rhg does is read-only.
// When it starts writing to the repository, it’ll need to either keep the // When it starts writing to the repository, it’ll need to either keep the
// persistent nodemap up to date or remove this entry: // persistent nodemap up to date or remove this entry:
NODEMAP_REQUIREMENT, NODEMAP_REQUIREMENT,
// Not all commands support `sparse` and `narrow`. The commands that do // Not all commands support `sparse` and `narrow`. The commands that do
// not should opt out by checking `has_sparse` and `has_narrow`. // not should opt out by checking `has_sparse` and `has_narrow`.
SPARSE_REQUIREMENT, SPARSE_REQUIREMENT,
NARROW_REQUIREMENT, NARROW_REQUIREMENT,
// rhg doesn't care about bookmarks at all yet
BOOKMARKS_IN_STORE_REQUIREMENT,
]; ];
// Copied from mercurial/requirements.py: // Copied from mercurial/requirements.py:
pub(crate) const DIRSTATE_V2_REQUIREMENT: &str = "dirstate-v2"; pub(crate) const DIRSTATE_V2_REQUIREMENT: &str = "dirstate-v2";
/// When narrowing is finalized and no longer subject to format changes, /// When narrowing is finalized and no longer subject to format changes,
/// we should move this to just "narrow" or similar. /// we should move this to just "narrow" or similar.
#[allow(unused)] #[allow(unused)]
pub(crate) const NARROW_REQUIREMENT: &str = "narrowhg-experimental"; pub(crate) const NARROW_REQUIREMENT: &str = "narrowhg-experimental";
/// Bookmarks must be stored in the `store` part of the repository and will be
/// share accross shares
#[allow(unused)]
pub(crate) const BOOKMARKS_IN_STORE_REQUIREMENT: &str = "bookmarksinstore";
/// Enables sparse working directory usage /// Enables sparse working directory usage
#[allow(unused)] #[allow(unused)]
pub(crate) const SPARSE_REQUIREMENT: &str = "exp-sparse"; pub(crate) const SPARSE_REQUIREMENT: &str = "exp-sparse";
/// Enables the internal phase which is used to hide changesets instead /// Enables the internal phase which is used to hide changesets instead
/// of stripping them /// of stripping them
#[allow(unused)] #[allow(unused)]
pub(crate) const INTERNAL_PHASE_REQUIREMENT: &str = "internal-phase"; pub(crate) const INTERNAL_PHASE_REQUIREMENT: &str = "internal-phase";