( )⚙ D12550 absorb: make `--edit-lines` imply `--apply-changes`

This is an archive of the discontinued Mercurial Phabricator instance.

absorb: make `--edit-lines` imply `--apply-changes`
AcceptedPublic

Authored by martinvonz on Wed, Apr 13, 11:11 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Summary

One of our users tried to use hg absorb -e but it seemed that it
would only bring up the editor if there were no changes the command
could automatically detect destination for. I spent probably half an
hour debugging why it worked that way. I finally figured out that it
does bring up the editor, but you have to answer "yes" to the "apply
changes" prompt *first*. That seems very unintuitive. If the user
wants to edit the changes, there seems to be little reason to present
them with a prompt first, so let's have -e/--edit-lines imply
-a/--apply-changes. All the tests using -e also already used
-a. I changed them to rely on the implied -a so we get coverage of
that.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

martinvonz created this revision.Wed, Apr 13, 11:11 AM
Alphare accepted this revision.Thu, Apr 14, 4:45 AM
This revision is now accepted and ready to land.Thu, Apr 14, 4:45 AM