This is an archive of the discontinued Mercurial Phabricator instance.

setup: fix the py2exe logic to work with py3
AcceptedPublic

Authored by mharbison72 on Wed, Apr 13, 6:47 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Summary

TortoiseHg still uses (the modernized) py2exe packaging, but the build was
failing since py2exe.Distribution was removed.

One thing to note is that later in this module, there's a hack to include
distutils when building from a virtualenv. While import distutils works in
hg debugshell when built with py2, it doesn't work in py3. I'm not sure why-
I don't see it in library.zip either. It doesn't seem to break anything
though.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

mharbison72 created this revision.Wed, Apr 13, 6:47 PM
Alphare accepted this revision.Thu, Apr 14, 4:36 AM
This revision is now accepted and ready to land.Thu, Apr 14, 4:36 AM

Shouldn't this series (aside from the last one that is not supposed to be queued) be for stable?

Shouldn't this series (aside from the last one that is not supposed to be queued) be for stable?

D12555 should probably go on stable. But the rest would affect the py2 version of py2exe, and I don't want to break that. There was something in mercurial.thirdparty.concurrent that was py2-only syntax, and caused the py3 version of py2exe to break. So I' can't develop the py3 stuff from stable anyway.