This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Needs Review	martinvonz	D12494 [RFC] rust-revlog: create nodemap on the fly if it's not persisted
Needs Review	martinvonz	D12424 rust: upgrade zstd from 0.5.3 to 0.11.1
Accepted	martinvonz	D12548 changelog: avoid copying changeset data into `ChangesetRevisionData`
Accepted	martinvonz	D12486 rust-nodemap: remove unnecessary explicit lifetime
Needs Review	martinvonz	D12562 repo: extract a function for checking nodemap requirement
Needs Review	martinvonz	D12561 rust-revlog: make `Changelog` and `ManifestLog` unaware of `Repo`
Closed	martinvonz	D12442 rust-revlog: add methods for getting parent revs and entries
Accepted	martinvonz	D12547 rust-revlog: make unaware of `Repo`
Accepted	martinvonz	D12558 rust-filelog: don't use persistent nodemap (to match Python)
Needs Review	martinvonz	D12546 rust-revlog: move check for nodemap requirement to caller
Accepted	martinvonz	D12545 rust-nodemap-docket: make unaware of `Repo`
Accepted	martinvonz	D12544 rust-nodemap-docket: move check of nodemap requirement to caller
Closed	martinvonz	D12439 rust-changelog: start parsing changeset data
Closed	martinvonz	D12438 rust-changelog: remove special parsing of empty changelog data for null rev
Closed	martinvonz	D12426 rust-changelog: don't skip empty lines when iterating over changeset lines
Closed	martinvonz	D12425 rust-requirements: allow loading repos with `bookmarksinstore` requirement

Diff 33185

rust/hg-core/src/repo.rs

	pub fn has_sparse(&self) -> bool {			pub fn has_sparse(&self) -> bool {
	self.requirements.contains(requirements::SPARSE_REQUIREMENT)			self.requirements.contains(requirements::SPARSE_REQUIREMENT)
	}			}

	pub fn has_narrow(&self) -> bool {			pub fn has_narrow(&self) -> bool {
	self.requirements.contains(requirements::NARROW_REQUIREMENT)			self.requirements.contains(requirements::NARROW_REQUIREMENT)
	}			}

				pub fn has_nodemap(&self) -> bool {
				self.requirements
				.contains(requirements::NODEMAP_REQUIREMENT)
				martinvonzAuthorUnsubmitted Done This really is how `rustfmt` wants it. The line is only 69 characters if joined. martinvonz: This really is how `rustfmt` wants it. The line is only 69 characters if joined.
				}

	fn dirstate_file_contents(&self) -> Result<Vec<u8>, HgError> {			fn dirstate_file_contents(&self) -> Result<Vec<u8>, HgError> {
	Ok(self			Ok(self
	.hg_vfs()			.hg_vfs()
	.read("dirstate")			.read("dirstate")
	.io_not_found_as_none()?			.io_not_found_as_none()?
	.unwrap_or(Vec::new()))			.unwrap_or(Vec::new()))
	}			}


	pub fn dirstate_map_mut(			pub fn dirstate_map_mut(
	&self,			&self,
	) -> Result<RefMut<OwningDirstateMap>, DirstateError> {			) -> Result<RefMut<OwningDirstateMap>, DirstateError> {
	self.dirstate_map.get_mut_or_init(self)			self.dirstate_map.get_mut_or_init(self)
	}			}

	fn new_changelog(&self) -> Result<Changelog, HgError> {			fn new_changelog(&self) -> Result<Changelog, HgError> {
	let use_nodemap = self			Changelog::open(&self.store_vfs(), self.has_nodemap())
	.requirements
	.contains(requirements::NODEMAP_REQUIREMENT);
	Changelog::open(&self.store_vfs(), use_nodemap)
	}			}

	pub fn changelog(&self) -> Result<Ref<Changelog>, HgError> {			pub fn changelog(&self) -> Result<Ref<Changelog>, HgError> {
	self.changelog.get_or_init(self)			self.changelog.get_or_init(self)
	}			}

	pub fn changelog_mut(&self) -> Result<RefMut<Changelog>, HgError> {			pub fn changelog_mut(&self) -> Result<RefMut<Changelog>, HgError> {
	self.changelog.get_mut_or_init(self)			self.changelog.get_mut_or_init(self)
	}			}

	fn new_manifestlog(&self) -> Result<Manifestlog, HgError> {			fn new_manifestlog(&self) -> Result<Manifestlog, HgError> {
	let use_nodemap = self			Manifestlog::open(&self.store_vfs(), self.has_nodemap())
	.requirements
	.contains(requirements::NODEMAP_REQUIREMENT);
	Manifestlog::open(&self.store_vfs(), use_nodemap)
	}			}

	pub fn manifestlog(&self) -> Result<Ref<Manifestlog>, HgError> {			pub fn manifestlog(&self) -> Result<Ref<Manifestlog>, HgError> {
	self.manifestlog.get_or_init(self)			self.manifestlog.get_or_init(self)
	}			}

	pub fn manifestlog_mut(&self) -> Result<RefMut<Manifestlog>, HgError> {			pub fn manifestlog_mut(&self) -> Result<RefMut<Manifestlog>, HgError> {
	self.manifestlog.get_mut_or_init(self)			self.manifestlog.get_mut_or_init(self)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	33185			Fri, Apr 15, 12:52 PM	★	★

This is an archive of the discontinued Mercurial Phabricator instance.

repo: extract a function for checking nodemap requirementNeeds ReviewPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 33185

rust/hg-core/src/repo.rs

repo: extract a function for checking nodemap requirement
Needs ReviewPublic

Revision Contents
Changeset List