This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12587

color: support the NO_COLOR environment variable
Changes PlannedPublic

Authored by Alphare on Apr 26 2022, 6:29 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

The https://no-color.org initiative is a good idea, it's easy to support. It
even explicitly lists Mercurial as one of the programs that don't support it.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Alphare created this revision.Apr 26 2022, 6:29 AM
Alphare planned changes to this revision.Apr 26 2022, 6:30 AM

Wait, this is not the right precedence, it should honor config.

av6 added a subscriber: av6.May 2 2022, 6:16 AM

I like seeing support of community standards that underline how one size^W default configuration doesn't fit all, so I think this is a great feature. Hopefully it won't be too hard to implement.

explicitly lists Mercurial as one of the programs that don't support it

Ouch.

Revision Contents
Changeset List

PathPackages
Mmercurial/color.py (2 lines)
Mtests/test-status-color.t (9 lines)

Diff 33313

mercurial/color.py

the configuration looking for custom colors and effect definitions.""" the configuration looking for custom colors and effect definitions."""
mode = _modesetup(ui) mode = _modesetup(ui)
ui._colormode = mode ui._colormode = mode
if mode and mode != b'debug': if mode and mode != b'debug':
configstyles(ui) configstyles(ui)
def _modesetup(ui): def _modesetup(ui):
if ui.plain(b'color'): if ui.plain(b'color') or encoding.environ.get(b"NO_COLOR") is not None:
return None return None
config = ui.config(b'ui', b'color') config = ui.config(b'ui', b'color')
if config == b'debug': if config == b'debug':
return b'debug' return b'debug'
auto = config == b'auto' auto = config == b'auto'
always = False always = False
if not auto and stringutil.parsebool(config): if not auto and stringutil.parsebool(config):

tests/test-status-color.t

$ HGPLAINEXCEPT=color hg status --color=debug $ HGPLAINEXCEPT=color hg status --color=debug
[status.unknown|? ][status.unknown|a/1/in_a_1] (glob) [status.unknown|? ][status.unknown|a/1/in_a_1] (glob)
[status.unknown|? ][status.unknown|a/in_a] (glob) [status.unknown|? ][status.unknown|a/in_a] (glob)
[status.unknown|? ][status.unknown|b/1/in_b_1] (glob) [status.unknown|? ][status.unknown|b/1/in_b_1] (glob)
[status.unknown|? ][status.unknown|b/2/in_b_2] (glob) [status.unknown|? ][status.unknown|b/2/in_b_2] (glob)
[status.unknown|? ][status.unknown|b/in_b] (glob) [status.unknown|? ][status.unknown|b/in_b] (glob)
[status.unknown|? ][status.unknown|in_root] [status.unknown|? ][status.unknown|in_root]
NO_COLOR disables color no matter what
$ NO_COLOR= HGPLAINEXCEPT=color hg status --color=debug
? a/1/in_a_1 (glob)
? a/in_a (glob)
? b/1/in_b_1 (glob)
? b/2/in_b_2 (glob)
? b/in_b (glob)
? in_root
hg status with template hg status with template
$ hg status -T "{label('red', path)}\n" --color=debug $ hg status -T "{label('red', path)}\n" --color=debug
[red|a/1/in_a_1] [red|a/1/in_a_1]
[red|a/in_a] [red|a/in_a]
[red|b/1/in_b_1] [red|b/1/in_b_1]
[red|b/2/in_b_2] [red|b/2/in_b_2]
[red|b/in_b] [red|b/in_b]
[red|in_root] [red|in_root]