This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12597

followlines: don't put Unicode directly into the .js file (issue6559)
ClosedPublic

Authored by av6 on May 2 2022, 4:48 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG2c0570a6d5ae: followlines: don't put Unicode directly into the .js file (issue6559)
Summary

Apparently some web server setups may serve this file in a different encoding
than UTF-8, and that results in visual garbage in the followlines button that
renders for every line in a file. So instead of using this Unicode character in
UTF-8 we can encode it as \u2212. Or, to be more explicit, we can use −
HTML entity, which resolves into exactly that character.

Since now we're using innerHTML property to set the minus part of the button,
let's use it to set the plus part as well (even though the plus sign was plain
ASCII). A wise man once said "A foolish consistency is the hobgob... eh,
whatever." Throw a brick at me if this makes things worse.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

Diff 33378

mercurial/templates/static/followlines.js

//** return a <button> element with +/- spans */ //** return a <button> element with +/- spans */
function createButton() { function createButton() {
var btn = document.createElement('button'); var btn = document.createElement('button');
btn.title = btnTitleStart; btn.title = btnTitleStart;
btn.classList.add('btn-followlines'); btn.classList.add('btn-followlines');
var plusSpan = document.createElement('span'); var plusSpan = document.createElement('span');
plusSpan.classList.add('followlines-plus'); plusSpan.classList.add('followlines-plus');
plusSpan.textContent = '+'; plusSpan.innerHTML = '&plus;';
btn.appendChild(plusSpan); btn.appendChild(plusSpan);
var br = document.createElement('br'); var br = document.createElement('br');
btn.appendChild(br); btn.appendChild(br);
var minusSpan = document.createElement('span'); var minusSpan = document.createElement('span');
minusSpan.classList.add('followlines-minus'); minusSpan.classList.add('followlines-minus');
minusSpan.textContent = '−'; minusSpan.innerHTML = '&minus;';
btn.appendChild(minusSpan); btn.appendChild(minusSpan);
return btn; return btn;
} }
// extend DOM with CSS class for selection highlight and action buttons // extend DOM with CSS class for selection highlight and action buttons
var followlinesButtons = []; var followlinesButtons = [];
for (var i = 0; i < selectableElements.length; i++) { for (var i = 0; i < selectableElements.length; i++) {
selectableElements[i].classList.add('followlines-select'); selectableElements[i].classList.add('followlines-select');