This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12599

doc: use an absolute path in sys.path to work around a python DLL loading bug
ClosedPublic

Authored by mharbison72 on May 2 2022, 10:07 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG1b6e381521c5: doc: use an absolute path in sys.path to work around a python DLL loading bug
Summary

This bug[1] was causing the zstd entry under "Available Compression Engines" to
be omitted from the documentation for some versions of python3. I could
upgrade, but past upgrades have broken venvs and clobbered installed packages.
It's a trivial workaround, so there's no sense in leaving this subtle issue. It
was flushed out by changing the module policy here from 'allow' to 'c', and
seeing this error:

ImportError: DLL load failed while importing parsers: The parameter is incorrect.

[1] https://github.com/python/cpython/issues/87271

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.May 2 2022, 10:07 PM
Alphare accepted this revision.May 3 2022, 4:30 AM
Alphare added a subscriber: Alphare.

I feel like this should be on stable?

This revision is now accepted and ready to land.May 3 2022, 4:30 AM
mharbison72 added a comment.May 3 2022, 9:58 AM
In D12599#192902, @Alphare wrote:

I feel like this should be on stable?

Good call. I noticed this building the thg installer (which needs default), but it also affects PyOxidizer builds.

Revision Contents
Changeset List

PathPackages
Mdoc/gendoc.py (2 lines)

Diff 33334

doc/gendoc.py

msvcrt.setmode(sys.stderr.fileno(), os.O_BINARY) msvcrt.setmode(sys.stderr.fileno(), os.O_BINARY)
except ImportError: except ImportError:
pass pass
# This script is executed during installs and may not have C extensions # This script is executed during installs and may not have C extensions
# available. Relax C module requirements. # available. Relax C module requirements.
os.environ['HGMODULEPOLICY'] = 'allow' os.environ['HGMODULEPOLICY'] = 'allow'
# import from the live mercurial repo # import from the live mercurial repo
sys.path.insert(0, "..") sys.path.insert(0, os.path.abspath(".."))
from mercurial import demandimport from mercurial import demandimport
demandimport.enable() demandimport.enable()
from mercurial import ( from mercurial import (
commands, commands,
encoding, encoding,
extensions, extensions,