This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12615

auto-upgrade: add a test case with no permission to lock the repository
ClosedPublic

Authored by marmoute on Fri, May 6, 4:37 AM.

Download Raw Diff

Details

Reviewers

Alphare

Group Reviewers

hg-reviewers

Commits

rHG1c233af99316: auto-upgrade: add a test case with no permission to lock the repository

Summary

This show the current behavior when the repository is unlockable.

The current behavior is to abort, which is probably not great. Now that we have
a proper test, we can think about the behavior we want in a later changeset.

Diff Detail

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Fri, May 6, 4:37 AM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptFri, May 6, 4:37 AM

Herald added a subscriber: mercurial-patches. · View Herald Transcript

marmoute added a child revision: D12616: debuglock: make the command more useful in non-interactive mode.Fri, May 6, 4:37 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare accepted this revision.Tue, May 24, 9:33 AM

This revision is now accepted and ready to land.Tue, May 24, 9:33 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute added a commit: rHG1c233af99316: auto-upgrade: add a test case with no permission to lock the repository.Tue, May 24, 10:50 AM

Closed by commit rHG1c233af99316: auto-upgrade: add a test case with no permission to lock the repository (authored by marmoute). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			tests/test-upgrade-repo.t (15 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	33367		Fri, May 6, 4:37 AM	★	★
Diff 2	33413		Thu, May 19, 6:36 AM	★	★
Diff 3	33428		Tue, May 24, 10:33 AM	★	★
Diff 4	33438	rHG1c233af99316878e44468d5a5617cda275008d57	Apr 4 2022, 9:36 PM	★	★

Status	Author	Revision
Closed	marmoute	D12619 auto-upgrade: skip the operation if the repository cannot be locked
Closed	marmoute	D12618 auto-upgrade: add a test case where the repository is already locked
Closed	marmoute	D12617 wait-on-file: properly wait on any files and symlink
Closed	marmoute	D12616 debuglock: make the command more useful in non-interactive mode
Closed	marmoute	D12615 auto-upgrade: add a test case with no permission to lock the repository
Closed	marmoute	D12614 auto-upgrade: introduce a way to auto-upgrade to/from dirstate-v2
Closed	marmoute	D12613 auto-upgrade: introduce a way to auto-upgrade to/from tracked-hint
Closed	marmoute	D12612 upgrade: split some logic from UpgradeOperation
Closed	marmoute	D12611 auto-upgrade: introduce a way to auto-upgrade to/from share-safe
Closed	marmoute	D12610 rust: make requirements public

Diff 33438

tests/test-upgrade-repo.t

	(see `hg help config.format.use-share-safe` for details)			(see `hg help config.format.use-share-safe` for details)
	automatically downgrading repository from the `tracked-hint` feature			automatically downgrading repository from the `tracked-hint` feature
	(see `hg help config.format.use-dirstate-tracked-hint` for details)			(see `hg help config.format.use-dirstate-tracked-hint` for details)
	$ hg debugformat -R auto-upgrade \| egrep '(dirstate-v2\|tracked\|share-safe)'			$ hg debugformat -R auto-upgrade \| egrep '(dirstate-v2\|tracked\|share-safe)'
	dirstate-v2: yes			dirstate-v2: yes
	tracked-hint: no			tracked-hint: no
	share-safe: yes			share-safe: yes

				Attempting Auto-upgrade on a read-only repository
				-------------------------------------------------

				$ chmod -R a-w auto-upgrade

				$ hg status -R auto-upgrade \
				> --config format.use-dirstate-v2.automatic-upgrade-of-mismatching-repositories=yes \
				> --config format.use-dirstate-v2=no
				abort: could not lock working directory of auto-upgrade: Permission denied
				[20]
				$ hg debugformat -R auto-upgrade \| grep dirstate-v2
				dirstate-v2: yes

				$ chmod -R u+w auto-upgrade