This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12620

tests: make sure .js files stay in ASCII encoding (issue6559)
ClosedPublic

Authored by av6 on Mon, May 9, 1:07 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG237855525f64: tests: make sure .js files stay in ASCII encoding (issue6559)

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

av6 created this revision.Mon, May 9, 1:07 PM
Alphare accepted this revision.Tue, May 24, 8:43 AM
Alphare added a subscriber: Alphare.

Thanks (sorry for the delay, I was away for work, then sick)

This revision is now accepted and ready to land.Tue, May 24, 8:43 AM
baymax updated this revision to Diff 33419.Tue, May 24, 9:35 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Revision Contents
Changeset List

PathPackages
AMtests/test-check-encoding.t (26 lines)

Diff 33421

tests/test-check-encoding.t

  • This file was added.
#require test-repo hg10
$ . "$TESTDIR/helpers-testrepo.sh"
$ cat > $TESTTMP/check_ascii.py <<EOF
> import sys
> for file_path in sys.argv[1:]:
> with open(file_path, 'br') as f:
> try:
> f.read().decode('ascii', 'strict')
> except UnicodeDecodeError as exc:
> print('%s: %s' % (file_path, exc))
> EOF
There are some web servers in the wild that can serve static files with an
incorrect encoding (e.g. https://bz.mercurial-scm.org/show_bug.cgi?id=6559).
One way to prevent any issues is to not use any non-ASCII characters, e.g.
URL-encoding them or using HTML entities.
check charset of all tracked files ending in .js
$ cd "`dirname "$TESTDIR"`"
$ testrepohg locate 'set:**.js' \
> 2>/dev/null \
> | xargs "$PYTHON" $TESTTMP/check_ascii.py