This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12626

revlog: use %d to format int instead of %lu (issue6565)
AbandonedPublic

Authored by av6 on Tue, May 17, 2:14 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

The issue says gcc warns that the data types don't match. I couldn't reproduce
the warning locally for some reason, but this patch shouldn't break things.
Maybe %lu was simply a copy-paste error from 6b1eae313b2f
(https://phab.mercurial-scm.org/D10625).

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

av6 created this revision.Tue, May 17, 2:14 PM
joerg.sonnenberger added a subscriber: joerg.sonnenberger.Tue, May 17, 2:48 PM

I think there are two issues here. The format string in line 500 doesn't match 492 and the format string in 494 doesn't either.

Revision Contents
Changeset List

PathPackages
Mmercurial/cext/revlog.c (2 lines)

Diff 33405

mercurial/cext/revlog.c

int header; int header;
char out[4]; char out[4];
if (!PyArg_ParseTuple(args, "I", &header)) { if (!PyArg_ParseTuple(args, "I", &header)) {
return NULL; return NULL;
} }
if (self->format_version != format_v1) { if (self->format_version != format_v1) {
PyErr_Format(PyExc_RuntimeError, PyErr_Format(PyExc_RuntimeError,
"version header should go in the docket, not the " "version header should go in the docket, not the "
"index: %lu", "index: %d",
header); header);
return NULL; return NULL;
} }
putbe32(header, out); putbe32(header, out);
return PyBytes_FromStringAndSize(out, 4); return PyBytes_FromStringAndSize(out, 4);
} }
/* /*
* Return the raw binary string representing a revision * Return the raw binary string representing a revision