This is an archive of the discontinued Mercurial Phabricator instance.


	class basepackstore(object):			class basepackstore(object):
	def __init__(self, ui, path):			def __init__(self, ui, path):
	self.path = path			self.path = path
	self.packs = []			self.packs = []
	# lastrefesh is 0 so we'll immediately check for new packs on the first			# lastrefesh is 0 so we'll immediately check for new packs on the first
	# failure.			# failure.
	self.lastrefresh = 0			self.lastrefresh = 0
				totalsize = 0
	for filepath in self._getavailablepackfiles():			for filepath, size in self._getavailablepackfiles():
	try:			try:
	pack = self.getpack(filepath)			pack = self.getpack(filepath)
				totalsize += size
	except Exception as ex:			except Exception as ex:
	# An exception may be thrown if the pack file is corrupted			# An exception may be thrown if the pack file is corrupted
	# somehow. Log a warning but keep going in this case, just			# somehow. Log a warning but keep going in this case, just
	# skipping this pack file.			# skipping this pack file.
	#			#
	# If this is an ENOENT error then don't even bother logging.			# If this is an ENOENT error then don't even bother logging.
	# Someone could have removed the file since we retrieved the			# Someone could have removed the file since we retrieved the
	# list of paths.			# list of paths.
	if getattr(ex, 'errno', None) != errno.ENOENT:			if getattr(ex, 'errno', None) != errno.ENOENT:
	ui.warn(_('unable to load pack %s: %s\n') % (filepath, ex))			ui.warn(_('unable to load pack %s: %s\n') % (filepath, ex))
	continue			continue
	self.packs.append(pack)			self.packs.append(pack)
	numpacks = len(self.packs)			numpacks = len(self.packs)
	ui.log("packsizes", "packstore %s has %d packs\n" % (path, numpacks),			ui.log("packsizes", "packstore %s has %d packs totaling %s\n" %
	numpacks=numpacks)			(path, numpacks, util.bytecount(totalsize)),
				numpacks=numpacks,
				totalsize=totalsize)

	def _getavailablepackfiles(self):			def _getavailablepackfiles(self):
				durhamUnsubmitted Not Done The output of this is used in other places that I think need updating. durham: The output of this is used in other places that I think need updating.
				singhsrbUnsubmitted Not Done Can we just log inside the _getavailablepackfiles? singhsrb: Can we just log inside the _getavailablepackfiles?
				phillcoAuthorUnsubmitted Not Done Would that be preferable? phillco: Would that be preferable?
				durhamUnsubmitted Not Done Hmm, actually yea that might be nicer. Since then we would also catch refreshes. durham: Hmm, actually yea that might be nicer. Since then we would also catch refreshes.
				phillcoAuthorUnsubmitted Not Done willdo phillco: willdo
	suffixlen = len(self.INDEXSUFFIX)			suffixlen = len(self.INDEXSUFFIX)

	files = []			files = []
	filenames = set()			filenames = set()
	try:			try:
	for filename, size, stat in osutil.listdir(self.path, stat=True):			for filename, size, stat in osutil.listdir(self.path, stat=True):
	files.append((stat.st_mtime, filename))			files.append((stat.st_mtime, size, filename))
	filenames.add(filename)			filenames.add(filename)
	except OSError as ex:			except OSError as ex:
	if ex.errno != errno.ENOENT:			if ex.errno != errno.ENOENT:
	raise			raise

	# Put most recent pack files first since they contain the most recent			# Put most recent pack files first since they contain the most recent
	# info.			# info.
	files = sorted(files, reverse=True)			files = sorted(files, reverse=True)
	for mtime, filename in files:			for mtime, size, filename in files:
	packfilename = '%s%s' % (filename[:-suffixlen], self.PACKSUFFIX)			packfilename = '%s%s' % (filename[:-suffixlen], self.PACKSUFFIX)
	if (filename[-suffixlen:] == self.INDEXSUFFIX			if (filename[-suffixlen:] == self.INDEXSUFFIX
	and packfilename in filenames):			and packfilename in filenames):
	yield os.path.join(self.path, filename)[:-suffixlen]			yield os.path.join(self.path, filename)[:-suffixlen], size

	def getpack(self, path):			def getpack(self, path):
	raise NotImplemented()			raise NotImplemented()

	def getmissing(self, keys):			def getmissing(self, keys):
	missing = keys			missing = keys
	for pack in self.packs:			for pack in self.packs:
	missing = pack.getmissing(missing)			missing = pack.getmissing(missing)
	# new objects), let's only actually check disk for new stuff every once			# new objects), let's only actually check disk for new stuff every once
	# in a while. Generally this code path should only ever matter when a			# in a while. Generally this code path should only ever matter when a
	# repack is going on in the background, and that should be pretty rare			# repack is going on in the background, and that should be pretty rare
	# to have that happen twice in quick succession.			# to have that happen twice in quick succession.
	newpacks = []			newpacks = []
	if now > self.lastrefresh + REFRESHRATE:			if now > self.lastrefresh + REFRESHRATE:
	self.lastrefresh = now			self.lastrefresh = now
	previous = set(p.path for p in self.packs)			previous = set(p.path for p in self.packs)
	new = set(self._getavailablepackfiles()) - previous			files = [f for f, size in self._getavailablepackfiles()]
				new = set(files) - previous
				durhamUnsubmitted Not Done Like here durham: Like here

	for filepath in new:			for filepath in new:
	newpacks.append(self.getpack(filepath))			newpacks.append(self.getpack(filepath))
	self.packs.extend(newpacks)			self.packs.extend(newpacks)

	return newpacks			return newpacks

	class versionmixin(object):			class versionmixin(object):

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	3192		Nov 1 2017, 2:45 PM	★	★
Diff 2	3193		Nov 1 2017, 3:41 PM	★	★
Diff 3	3194		Nov 1 2017, 3:52 PM	★	★

This is an archive of the discontinued Mercurial Phabricator instance.

basepack: also log total size of packs on initClosedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 3193

remotefilelog/basepack.py

basepack: also log total size of packs on init
ClosedPublic

Revision Contents
Changeset List