This is an archive of the discontinued Mercurial Phabricator instance.

check-ext: ignore pyc files
ClosedPublic

Authored by quark on Nov 1 2017, 8:22 PM.

Reviewers

durham

Group Reviewers

Restricted Project

Commits

rFBHGXfd89ab2d18bb: check-ext: ignore pyc files

Summary

.pyc files could cause false positive. Scan .py and .pyx files
explicitly.

Test Plan

Make sure uncommit.pyc will not break check-code but uncommit.pyx,
uncommit.py will.

Repository

rFBHGX Facebook Mercurial Extensions

Lint

Lint Skipped

Unit

Unit Tests Skipped

This revision is now accepted and ready to land.Nov 1 2017, 8:23 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			tests/check-ext.py (4 lines)

	"""			"""

	# whitelisted foreign extensions			# whitelisted foreign extensions
	foreignexts = set(['remotenames'])			foreignexts = set(['remotenames'])
	foreignextre = re.compile(r'(%s)' % '\|'.join(foreignexts))			foreignextre = re.compile(r'(%s)' % '\|'.join(foreignexts))

	# extensions in this repo			# extensions in this repo
	repoexts = set(os.path.basename(p).split('.')[0]			repoexts = set(os.path.basename(p).split('.')[0]
	for p in glob('hgext3rd/.py') if '__' not in p)			for p in glob('hgext3rd/*.py') if '__' not in p)
				repoexts.update(os.path.basename(p).split('.')[0]
				for p in glob('hgext3rd/*.pyx'))
	repoexts.update(os.path.basename(os.path.dirname(p))			repoexts.update(os.path.basename(os.path.dirname(p))
	for p in glob('hgext3rd/*/__init__.py'))			for p in glob('hgext3rd/*/__init__.py'))
	repoexts.update(os.path.basename(os.path.dirname(p))			repoexts.update(os.path.basename(os.path.dirname(p))
	for p in glob('*/__init__.py'))			for p in glob('*/__init__.py'))
	repoextre = re.compile(r'(%s)' % '\|'.join(repoexts))			repoextre = re.compile(r'(%s)' % '\|'.join(repoexts))

	checkres = [			checkres = [
	(re.compile(r'^\s>\s%s\s=\s$' % foreignextre.pattern),			(re.compile(r'^\s>\s%s\s=\s$' % foreignextre.pattern),