This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1298

py3: handle keyword arguments in hgext/children.py
ClosedPublic

Authored by pulkit on Nov 2 2017, 5:14 PM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHG11a372d80496: py3: handle keyword arguments in hgext/children.py
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Nov 2 2017, 5:14 PM
yuja accepted this revision.Nov 4 2017, 3:37 AM
This revision is now accepted and ready to land.Nov 4 2017, 3:37 AM
Closed by commit rHG11a372d80496: py3: handle keyword arguments in hgext/children.py (authored by pulkit). · Explain WhyNov 4 2017, 3:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/children.py (2 lines)

Diff 3235

hgext/children.py

"children(REV)"` instead. "children(REV)"` instead.
''' '''
from __future__ import absolute_import from __future__ import absolute_import
from mercurial.i18n import _ from mercurial.i18n import _
from mercurial import ( from mercurial import (
cmdutil, cmdutil,
pycompat,
registrar, registrar,
) )
templateopts = cmdutil.templateopts templateopts = cmdutil.templateopts
cmdtable = {} cmdtable = {}
command = registrar.command(cmdtable) command = registrar.command(cmdtable)
# Note for extension authors: ONLY specify testedwith = 'ships-with-hg-core' for # Note for extension authors: ONLY specify testedwith = 'ships-with-hg-core' for
Please use :hg:`log` instead:: Please use :hg:`log` instead::
hg children => hg log -r "children(.)" hg children => hg log -r "children(.)"
hg children -r REV => hg log -r "children(REV)" hg children -r REV => hg log -r "children(REV)"
See :hg:`help log` and :hg:`help revsets.children`. See :hg:`help log` and :hg:`help revsets.children`.
""" """
opts = pycompat.byteskwargs(opts)
rev = opts.get('rev') rev = opts.get('rev')
if file_: if file_:
fctx = repo.filectx(file_, changeid=rev) fctx = repo.filectx(file_, changeid=rev)
childctxs = [fcctx.changectx() for fcctx in fctx.children()] childctxs = [fcctx.changectx() for fcctx in fctx.children()]
else: else:
ctx = repo[rev] ctx = repo[rev]
childctxs = ctx.children() childctxs = ctx.children()
displayer = cmdutil.show_changeset(ui, repo, opts) displayer = cmdutil.show_changeset(ui, repo, opts)
for cctx in childctxs: for cctx in childctxs:
displayer.show(cctx) displayer.show(cctx)
displayer.close() displayer.close()