Commit a18eef03d879 made TESTDIR be the location of the arguments that were
passed to run-tests.py instead of just PWD. It assumed that these tests were
specified using relative paths, so if pwd was /tmp/foo, and the first argument
was /tmp/baz, it would set TESTDIR to /tmp/foo//tmp/baz.
Details
Details
Diff Detail
Diff Detail
- Repository
- rHG Mercurial
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Looks good, but perhaps we can simply do os.path.join(TESTDIR, pathname)
for any pathname.
Comment Actions
I didn't think that would work because of bytes, but apparently it does, at least on 2.7.13 and 3.5.3 on my linux machine. Done.
Comment Actions
Queued, thanks. FIle APIs still accept bytes/unicode on Py3.
tests/run-tests.py | ||
---|---|---|
2359–2361 | Restored if pathname: part, caught by test-run-tests.t |
Restored if pathname: part, caught by test-run-tests.t