( )⚙ D1471 setup: make rust nodemap buildable

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1471

setup: make rust nodemap buildable
ClosedPublic

Authored by quark on Nov 20 2017, 7:11 PM.
Tags
None
Subscribers
durham

Details

Reviewers
durham
Group Reviewers
Restricted Project
Commits
rFBHGX726dd074ea88: setup: make rust nodemap buildable
Summary

Thanks to D1411. It's now easy to add another rust module.

Test Plan

make local and make sure hgext3rd/rust/indexes.so is built and
importable.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

quark created this revision.Nov 20 2017, 7:11 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 20 2017, 7:11 PM
quark edited the test plan for this revision. (Show Details)Nov 22 2017, 8:45 PM
quark edited the summary of this revision. (Show Details)Nov 22 2017, 9:31 PM
durham accepted this revision.Dec 1 2017, 7:49 PM
durham added a subscriber: durham.
durham added inline comments.
setup.py
533

alphabetical!

This revision is now accepted and ready to land.Dec 1 2017, 7:49 PM
quark updated this revision to Diff 4371.Dec 11 2017, 7:20 PM
Closed by commit rFBHGX726dd074ea88: setup: make rust nodemap buildable (authored by quark). · Explain WhyDec 15 2017, 2:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msetup.py (4 lines)

Diff 4512

setup.py

# recursive glob # recursive glob
for dirname, dirs, files in os.walk('.'): for dirname, dirs, files in os.walk('.'):
for name in fnmatch.filter(files, patten): for name in fnmatch.filter(files, patten):
yield os.path.join(dirname, name) yield os.path.join(dirname, name)
rust_ext_modules = [] rust_ext_modules = []
if USERUST: if USERUST:
rust_ext_modules.extend([ rust_ext_modules.extend([
RustExtension('indexes',
package='hgext3rd.rust',
manifest='rust/indexes/Cargo.toml',
),
RustExtension('treedirstate', RustExtension('treedirstate',
package='hgext3rd.rust', package='hgext3rd.rust',
manifest='rust/treedirstate/Cargo.toml', manifest='rust/treedirstate/Cargo.toml',
), ),
]) ])
durhamUnsubmitted
Not Done

alphabetical!

durham: alphabetical!
setup( setup(
name='fbhgext', name='fbhgext',
version='1.0', version='1.0',
author='Facebook Source Control Team', author='Facebook Source Control Team',
maintainer='Facebook Source Control Team', maintainer='Facebook Source Control Team',
maintainer_email='sourcecontrol-dev@fb.com', maintainer_email='sourcecontrol-dev@fb.com',
url='https://bitbucket.org/facebook/hg-experimental/', url='https://bitbucket.org/facebook/hg-experimental/',