This is an archive of the discontinued Mercurial Phabricator instance.

py3: use byteskwargs in templatekw.showobsfate()
AbandonedPublic

Authored by indygreg on Nov 21 2017, 2:53 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Summary

According to the exceptions reporting mechanism, this is top crasher
#4, with 112 failures.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Nov 21 2017, 2:53 AM
pulkit requested changes to this revision.Nov 21 2017, 9:22 AM
pulkit added a subscriber: pulkit.
pulkit added inline comments.
mercurial/templatekw.py
610

I think we should swap the order of the above two lines. args is passed again as keyword argument.

This revision now requires changes to proceed.Nov 21 2017, 9:22 AM
indygreg abandoned this revision.Jan 14 2018, 3:09 PM

This was addressed by D1536.