Page MenuHomePhabricator

pushrebase: report details about public commits being pushed
ClosedPublic

Authored by simpkins on Nov 23 2017, 3:38 AM.

Details

Summary

When failing due to attempting to rebase already-public commits, include the
public commit node IDs in the error message.

Test Plan

Included new tests.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

simpkins created this revision.Nov 23 2017, 3:38 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 23 2017, 3:38 AM
quark accepted this revision.EditedNov 23 2017, 5:33 AM

Maybe we can show more information, like whether the nodes come from the received bundle or not. (I can do that as a follow up)

This revision is now accepted and ready to land.Nov 23 2017, 5:33 AM
durham accepted this revision.Nov 28 2017, 7:21 PM
This revision was automatically updated to reflect the committed changes.