This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1500

perftweaks: ignore errors caused by trackupdatesize
ClosedPublic

Authored by quark on Nov 23 2017, 5:27 PM.
Tags
None
Subscribers
None

Details

Reviewers
durham
Group Reviewers
Restricted Project
Commits
rFBHGX0a6720dc8335: perftweaks: ignore errors caused by trackupdatesize
Summary

When enabling the extensions and run tests in core hg, it sometimes raises

RepoLookupError: unknown revision '-1'

from the trackupdate code path. This is not a critical feature so let's just
ignore the error.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

quark created this revision.Nov 23 2017, 5:27 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 23 2017, 5:27 PM
durham accepted this revision.Nov 27 2017, 9:40 PM
This revision is now accepted and ready to land.Nov 27 2017, 9:40 PM
quark updated this revision to Diff 3989.Nov 29 2017, 8:40 PM
Closed by commit rFBHGX0a6720dc8335: perftweaks: ignore errors caused by trackupdatesize (authored by quark). · Explain WhyNov 29 2017, 10:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext3rd/perftweaks.py (8 lines)

Diff 3807

hgext3rd/perftweaks.py

if util.safehasattr(repo, 'getactiveprofiles'): if util.safehasattr(repo, 'getactiveprofiles'):
profiles = repo.getactiveprofiles() profiles = repo.getactiveprofiles()
lui.log('sparse_profiles', '', lui.log('sparse_profiles', '',
active_profiles=','.join(sorted(profiles))) active_profiles=','.join(sorted(profiles)))
return res return res
def _trackupdatesize(orig, repo, node, branchmerge, *args, **kwargs): def _trackupdatesize(orig, repo, node, branchmerge, *args, **kwargs):
if not branchmerge: if not branchmerge:
try:
distance = len(repo.revs('(%s %% .) + (. %% %s)', node, node)) distance = len(repo.revs('(%s %% .) + (. %% %s)', node, node))
repo.ui.log('update_size', '', update_distance=distance) repo.ui.log('update_size', '', update_distance=distance)
except Exception:
# error may happen like: RepoLookupError: unknown revision '-1'
pass
stats = orig(repo, node, branchmerge, *args, **kwargs) stats = orig(repo, node, branchmerge, *args, **kwargs)
repo.ui.log('update_size', '', update_filecount=sum(stats)) repo.ui.log('update_size', '', update_filecount=sum(stats))
return stats return stats
def _trackrebasesize(orig, self, destmap): def _trackrebasesize(orig, self, destmap):
result = orig(self, destmap) result = orig(self, destmap)
if not destmap: if not destmap: