This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1503

rewriteutil: add a precheck function to check if revs can be rewritten
ClosedPublic

Authored by pulkit on Nov 23 2017, 5:39 PM.

Details

Reviewers
dlax
durin42
Group Reviewers
hg-reviewers
Commits
rHG490df753894d: rewriteutil: add a precheck function to check if revs can be rewritten
Summary

The precheck function is intended to be used before we start rewritting
changesets.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Nov 23 2017, 5:39 PM
dlax accepted this revision.Nov 28 2017, 4:17 AM
pulkit updated this revision to Diff 3912.Nov 28 2017, 2:14 PM
durin42 accepted this revision.Dec 5 2017, 5:52 PM
This revision is now accepted and ready to land.Dec 5 2017, 5:52 PM
Closed by commit rHG490df753894d: rewriteutil: add a precheck function to check if revs can be rewritten (authored by pulkit). · Explain WhyDec 5 2017, 6:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/rewriteutil.py (28 lines)

Diff 3912

mercurial/rewriteutil.py

# rewriteutil.py - utility functions for rewriting changesets # rewriteutil.py - utility functions for rewriting changesets
# #
# Copyright 2017 Octobus <contact@octobus.net> # Copyright 2017 Octobus <contact@octobus.net>
# #
# This software may be used and distributed according to the terms of the # This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version. # GNU General Public License version 2 or any later version.
from __future__ import absolute_import from __future__ import absolute_import
from .i18n import _
from . import ( from . import (
error,
node,
obsolete, obsolete,
revset, revset,
) )
def precheck(repo, revs, action='rewrite'):
"""check if revs can be rewritten
action is used to control the error message.
Make sure this function is called after taking the lock.
"""
if node.nullrev in revs:
msg = _("cannot %s null changeset") % (action)
hint = _("no changeset checked out")
raise error.Abort(msg, hint=hint)
publicrevs = repo.revs('%ld and public()', revs)
if len(repo[None].parents()) > 1:
raise error.Abort(_("cannot %s while merging") % action)
if publicrevs:
msg = _("cannot %s public changesets") % (action)
hint = _("see 'hg help phases' for details")
raise error.Abort(msg, hint=hint)
newunstable = disallowednewunstable(repo, revs)
if newunstable:
raise error.Abort(_("cannot %s changeset with children") % action)
def disallowednewunstable(repo, revs): def disallowednewunstable(repo, revs):
"""Checks whether editing the revs will create new unstable changesets and """Checks whether editing the revs will create new unstable changesets and
are we allowed to create them. are we allowed to create them.
To allow new unstable changesets, set the config: To allow new unstable changesets, set the config:
`experimental.evolution.allowunstable=True` `experimental.evolution.allowunstable=True`
""" """
allowunstable = obsolete.isenabled(repo, obsolete.allowunstableopt) allowunstable = obsolete.isenabled(repo, obsolete.allowunstableopt)
if allowunstable: if allowunstable:
return revset.baseset() return revset.baseset()
return repo.revs("(%ld::) - %ld", revs, revs) return repo.revs("(%ld::) - %ld", revs, revs)