Page MenuHomePhabricator

treemanifest: fail gracefully in prefetch if no remote is configured

Authored by simpkins on Nov 28 2017, 11:34 PM.



If no remote path is configured raise an Abort exception, rather than returning
the path as None and crashing later on with an unfriendly exception due to
trying to use None as a string.

Test Plan

Updated test-treemanifest-prefetch.t to exercise this code.

Diff Detail

rFBHGX Facebook Mercurial Extensions
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

simpkins created this revision.Nov 28 2017, 11:34 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 28 2017, 11:34 PM
durham accepted this revision.Nov 29 2017, 2:45 PM
This revision is now accepted and ready to land.Nov 29 2017, 2:45 PM
singhsrb accepted this revision.Nov 29 2017, 4:11 PM
This revision was automatically updated to reflect the committed changes.