This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1541

treemanifest: fail gracefully in prefetch if no remote is configured
ClosedPublic

Authored by simpkins on Nov 28 2017, 11:34 PM.
Tags
None
Subscribers
None

Details

Reviewers
singhsrb
durham
Group Reviewers
Restricted Project
Commits
rFBHGXc270ea1bc98f: treemanifest: fail gracefully in prefetch if no remote is configured
Summary

If no remote path is configured raise an Abort exception, rather than returning
the path as None and crashing later on with an unfriendly exception due to
trying to use None as a string.

Test Plan

Updated test-treemanifest-prefetch.t to exercise this code.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

simpkins created this revision.Nov 28 2017, 11:34 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 28 2017, 11:34 PM
durham accepted this revision.Nov 29 2017, 2:45 PM
This revision is now accepted and ready to land.Nov 29 2017, 2:45 PM
singhsrb accepted this revision.Nov 29 2017, 4:11 PM
Closed by commit rFBHGXc270ea1bc98f: treemanifest: fail gracefully in prefetch if no remote is configured (authored by simpkins). · Explain WhyNov 29 2017, 10:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 3998

tests/test-treemanifest-prefetch.t

3 trees fetched over * (glob) 3 trees fetched over * (glob)
1 files fetched over 1 fetches - (1 misses, 0.00% hit ratio) over * (glob) 1 files fetched over 1 fetches - (1 misses, 0.00% hit ratio) over * (glob)
#else #else
The tree prefetching code path fetches no trees for revision 5. And there is no The tree prefetching code path fetches no trees for revision 5. And there is no
prefetching of files in this test case. prefetching of files in this test case.
$ hg prefetch $ hg prefetch
0 trees fetched over * (glob) 0 trees fetched over * (glob)
#endif #endif
Running prefetch in the master repository should fail gracefully
$ cd ../master
$ hg prefetch
abort: no remote server configured to fetch trees from
[255]

treemanifest/__init__.py

part.addparam('category', PACK_CATEGORY) part.addparam('category', PACK_CATEGORY)
return part return part
def getfallbackpath(repo): def getfallbackpath(repo):
if util.safehasattr(repo, 'fallbackpath'): if util.safehasattr(repo, 'fallbackpath'):
return repo.fallbackpath return repo.fallbackpath
else: else:
return repo.ui.config('paths', 'default') path = repo.ui.config('paths', 'default')
if not path:
raise error.Abort(
"no remote server configured to fetch trees from")
return path
def pull(orig, ui, repo, *pats, **opts): def pull(orig, ui, repo, *pats, **opts):
# If we're not in treeonly mode, and we're missing public commits from the # If we're not in treeonly mode, and we're missing public commits from the
# revlog, backfill them. # revlog, backfill them.
if not ui.configbool('treemanifest', 'treeonly'): if not ui.configbool('treemanifest', 'treeonly'):
tippublicrevs = repo.revs('last(public())') tippublicrevs = repo.revs('last(public())')
if tippublicrevs: if tippublicrevs:
ctx = repo[tippublicrevs.first()] ctx = repo[tippublicrevs.first()]